This is a start to implement the feature, later on we will need to expose dedicated tags in GStreamer to retrieve other informations about the Kind (I could not find a good match).
Created attachment 337998 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method In the playbin3 case we can assume that if the GstStream is selected by default, it is the Main track of that kind.
Created attachment 338000 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method In the playbin3 case we can assume that if the GstStream is selected by default, it is the Main track of that kind.
Comment on attachment 338000 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method View in context: https://bugs.webkit.org/attachment.cgi?id=338000&action=review > Source/WebCore/ChangeLog:12 > + No new tests are added as we already have a few ones that are currently disabled in > + the mediastream testsuite. This patch is part of the work to enable them. Maybe the media/ test suite has a test for this though? > Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:57 > + if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT) No space before ( please :) > Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:57 > + if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT) Ditto
Comment on attachment 338000 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method Attachment 338000 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7332931 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Created attachment 338022 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 338580 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method In the playbin3 case we can assume that if the GstStream is selected by default, it is the Main track of that kind.
(In reply to Philippe Normand from comment #3) > Comment on attachment 338000 [details] > [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338000&action=review > > > Source/WebCore/ChangeLog:12 > > + No new tests are added as we already have a few ones that are currently disabled in > > + the mediastream testsuite. This patch is part of the work to enable them. > > Maybe the media/ test suite has a test for this though? Enhanced the ChangeLog to explain why I didn't add tests. > > Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:57 > > + if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT) > > No space before ( please :) Fixed. > > > Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:57 > > + if (m_stream.get() && gst_stream_get_stream_flags (m_stream.get()) & GST_STREAM_FLAG_SELECT) > > Ditto Fixed.
Attachment 338580 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 338580 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method View in context: https://bugs.webkit.org/attachment.cgi?id=338580&action=review > Source/WebCore/ChangeLog:14 > + * It relies on playbin3 case which support might be compiled out > + * we already have a few test that are currently disabled in the mediastream > + testsuite. This patch is part of the work to enable them. s/*/- maybe?
Comment on attachment 338580 [details] [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method Clearing flags on attachment: 338580 Committed r230910: <https://trac.webkit.org/changeset/230910>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39644737>