Bug 184647 - [GLIB] Add API to query, delete and enumerate properties
Summary: [GLIB] Add API to query, delete and enumerate properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-04-16 06:18 PDT by Carlos Garcia Campos
Modified: 2018-04-17 01:16 PDT (History)
9 users (show)

See Also:


Attachments
Patch (24.68 KB, patch)
2018-04-16 06:21 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-04-16 06:18:08 PDT
ssia
Comment 1 Carlos Garcia Campos 2018-04-16 06:21:30 PDT
Created attachment 337994 [details]
Patch
Comment 2 Michael Catanzaro 2018-04-16 07:47:02 PDT
Comment on attachment 337994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337994&action=review

> Source/JavaScriptCore/API/glib/JSCValue.cpp:742
> + * Get whether @value has propety with @name.

property

> Source/JavaScriptCore/API/glib/JSCValue.cpp:758
> +
> +

Remove extra blank line

> Source/JavaScriptCore/API/glib/JSCValue.cpp:785
> +
> +

Ditto (you do want only one blank line here, right?)
Comment 3 Carlos Garcia Campos 2018-04-17 01:15:41 PDT
Committed r230704: <https://trac.webkit.org/changeset/230704>
Comment 4 Radar WebKit Bug Importer 2018-04-17 01:16:24 PDT
<rdar://problem/39484544>