Bug 184644 – [Web Animations] Ensure we never return -0 through the API

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[Web Animations] Ensure we never return -0 through the API

[Antoine Quint]

Created attachment 337991 [details]
Patch

[EWS Watchlist]

Comment on attachment 337991 [details]
Patch

Attachment 337991 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7328720

New failing tests:
animations/needs-layout.html

[EWS Watchlist]

Created attachment 337992 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antoine Quint]

Committed r230667: <https://trac.webkit.org/changeset/230667>

[Radar WebKit Bug Importer]

<rdar://problem/39450781>

[Darin Adler]

Comment on attachment 337991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337991&action=review

> Source/WebCore/animation/WebAnimationUtilities.h:43
> -    return std::round(time.microseconds()) / 1000;
> +    auto roundedTime = std::round(time.microseconds()) / 1000;
> +    if (roundedTime == -0)
> +        return 0;
> +    return roundedTime;

Another way to write it, less straightforward but a little cleaner maybe is to add 0, which turns -0 into +0.

    return std::round(time.microseconds()) / 1000 + 0; // Add 0 to convert -0 to +0.