Bug 184642 – [MSE] New SourceBuffers Objects from WebCore/JavaScript

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Eric Stobbart]

MediaSource.idl is using a cached wrapped object, causing SourceBuffers to leak.

[Eric Stobbart]

Created attachment 337987 [details]
Patch

[Eric Stobbart]

Created attachment 337995 [details]
Patch

[Eric Stobbart]

Created attachment 337999 [details]
Patch

[Eric Stobbart]

Created attachment 338003 [details]
Patch

[EWS Watchlist]

Comment on attachment 338003 [details]
Patch

Attachment 338003 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7331662

New failing tests:
compositing/debug-borders-dynamic.html

[EWS Watchlist]

Created attachment 338008 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Eric Stobbart]

Original description isn't as accurate as it should be.
Edited the title to better reflect the issue.

[Eric Stobbart]

Created attachment 338192 [details]
Patch

[Eric Stobbart]

I'm unable to reproduce these build failures locally.
Could someone help me look into this?

[EWS Watchlist]

Comment on attachment 338192 [details]
Patch

Attachment 338192 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7353004

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html

[EWS Watchlist]

Created attachment 338196 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Chris Dumez]

Comment on attachment 338192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338192&action=review

> Source/WebCore/Modules/mediasource/MediaSource.cpp:677
> +    return buffer;

return WTFMove(buffer); I think

[Eric Stobbart]

Created attachment 338295 [details]
Patch

[Eric Stobbart]

(In reply to Chris Dumez from comment #12)
> Comment on attachment 338192 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338192&action=review
> 
> > Source/WebCore/Modules/mediasource/MediaSource.cpp:677
> > +    return buffer;
> 
> return WTFMove(buffer); I think

Magic. Thanks man!

[Chris Dumez]

Comment on attachment 338295 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 338295 [details]
Patch

Clearing flags on attachment: 338295

Committed r230805: <https://trac.webkit.org/changeset/230805>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39565703>