Bug 184637 - [Cocoa] Adopt CCRSAGetCRTComponents and stop using CCBigNum
Summary: [Cocoa] Adopt CCRSAGetCRTComponents and stop using CCBigNum
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-15 13:04 PDT by Darin Adler
Modified: 2019-08-28 16:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.66 KB, patch)
2018-04-15 13:07 PDT, Darin Adler 		ap: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.22 MB, application/zip)
2018-04-15 14:12 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-04-15 13:04:46 PDT 
[Cocoa] Adopt CCRSAGetCRTComponents and stop using CCBigNum
Comment 1 Darin Adler 2018-04-15 13:07:14 PDT 
Created attachment 337974 [details]
Patch
Comment 2 Darin Adler 2018-04-15 13:09:11 PDT 
<rdar://problem/22670286>
Comment 3 Darin Adler 2018-04-15 13:09:24 PDT 
I compiled this, but didn’t test it yet because I don’t know how.
Comment 4 EWS Watchlist 2018-04-15 14:12:29 PDT 
Comment on attachment 337974 [details]
Patch

Attachment 337974 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7324829

New failing tests:
animations/needs-layout.html
Comment 5 EWS Watchlist 2018-04-15 14:12:30 PDT 
Created attachment 337976 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Alexey Proskuryakov 2018-04-15 16:20:28 PDT 
Comment on attachment 337974 [details]
Patch

Please run tests in crypto subdirectory before landing, as EWS doesn't exercise 10.13+ only code.
Comment 7 Darin Adler 2018-04-26 09:13:22 PDT 
I ran the crypto tests on macOS with 10.13.5 (an internal pre-release version, but should be fine) and all of them passed.
Comment 8 Darin Adler 2018-04-26 09:14:42 PDT 
Committed r231046: <https://trac.webkit.org/changeset/231046>
Comment 9 Radar WebKit Bug Importer 2018-04-26 09:15:32 PDT 
<rdar://problem/39759473>