WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184634
[iOS] Add API tests for PDF find-in-page
https://bugs.webkit.org/show_bug.cgi?id=184634
Summary
[iOS] Add API tests for PDF find-in-page
Andy Estes
Reported
2018-04-14 22:12:02 PDT
[iOS] Add API tests for PDF find-in-page
Attachments
Patch
(31.29 KB, patch)
2018-04-14 22:14 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-sierra
(2.21 MB, application/zip)
2018-04-14 23:20 PDT
,
EWS Watchlist
no flags
Details
Patch
(31.36 KB, patch)
2018-04-15 10:55 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2018-04-14 22:14:20 PDT
Created
attachment 337970
[details]
Patch
mitz
Comment 2
2018-04-14 22:22:11 PDT
Comment on
attachment 337970
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=337970&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:114 > + auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectZero]);
Can just use -init.
EWS Watchlist
Comment 3
2018-04-14 23:20:04 PDT
Comment on
attachment 337970
[details]
Patch
Attachment 337970
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/7320628
New failing tests: animations/needs-layout.html
EWS Watchlist
Comment 4
2018-04-14 23:20:05 PDT
Created
attachment 337971
[details]
Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Andy Estes
Comment 5
2018-04-15 10:55:07 PDT
Created
attachment 337973
[details]
Patch
WebKit Commit Bot
Comment 6
2018-04-15 11:44:47 PDT
The commit-queue encountered the following flaky tests while processing
attachment 337973
[details]
: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7
2018-04-15 14:21:22 PDT
The commit-queue encountered the following flaky tests while processing
attachment 337973
[details]
: animations/needs-layout.html
bug 184638
(author:
dino@apple.com
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8
2018-04-15 14:21:56 PDT
Comment on
attachment 337973
[details]
Patch Clearing flags on attachment: 337973 Committed
r230663
: <
https://trac.webkit.org/changeset/230663
>
WebKit Commit Bot
Comment 9
2018-04-15 14:21:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10
2018-04-15 14:22:36 PDT
<
rdar://problem/39444421
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug