Bug 184634 - [iOS] Add API tests for PDF find-in-page
Summary: [iOS] Add API tests for PDF find-in-page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-14 22:12 PDT by Andy Estes
Modified: 2018-04-15 14:22 PDT (History)
10 users (show)

See Also:

Attachments
Patch (31.29 KB, patch)
2018-04-14 22:14 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.21 MB, application/zip)
2018-04-14 23:20 PDT, EWS Watchlist 		no flags Details
Patch (31.36 KB, patch)
2018-04-15 10:55 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-04-14 22:12:02 PDT 
[iOS] Add API tests for PDF find-in-page
Comment 1 Andy Estes 2018-04-14 22:14:20 PDT 
Created attachment 337970 [details]
Patch
Comment 2 mitz 2018-04-14 22:22:11 PDT 
Comment on attachment 337970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337970&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:114
> +    auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectZero]);

Can just use -init.
Comment 3 EWS Watchlist 2018-04-14 23:20:04 PDT 
Comment on attachment 337970 [details]
Patch

Attachment 337970 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7320628

New failing tests:
animations/needs-layout.html
Comment 4 EWS Watchlist 2018-04-14 23:20:05 PDT 
Created attachment 337971 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Andy Estes 2018-04-15 10:55:07 PDT 
Created attachment 337973 [details]
Patch
Comment 6 WebKit Commit Bot 2018-04-15 11:44:47 PDT 
The commit-queue encountered the following flaky tests while processing attachment 337973 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-04-15 14:21:22 PDT 
The commit-queue encountered the following flaky tests while processing attachment 337973 [details]:

animations/needs-layout.html bug 184638 (author: dino@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2018-04-15 14:21:56 PDT 
Comment on attachment 337973 [details]
Patch

Clearing flags on attachment: 337973

Committed r230663: <https://trac.webkit.org/changeset/230663>
Comment 9 WebKit Commit Bot 2018-04-15 14:21:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-15 14:22:36 PDT 
<rdar://problem/39444421>