Bug 184630 – Function.prototype.caller shouldn't return generator bodies

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 337961 [details]
the patch

[Yusuke Suzuki]

Comment on attachment 337961 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337961&action=review

r=me, nice.

> JSTests/stress/function-caller-generator-body.js:24
> +})();

Can you add a test for,

1. Async functions, which uses generators internally
2. generator method functions like

class A {
    *gen() {
        ...
    }
}

var a = new A();
var gen = a.gen();

[Filip Pizlo]

(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 337961 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337961&action=review
> 
> r=me, nice.
> 
> > JSTests/stress/function-caller-generator-body.js:24
> > +})();
> 
> Can you add a test for,
> 
> 1. Async functions, which uses generators internally
> 2. generator method functions like
> 
> class A {
>     *gen() {
>         ...
>     }
> }
> 
> var a = new A();
> var gen = a.gen();

Good idea, will do.

[Filip Pizlo]

Created attachment 337962 [details]
patch for landing

[EWS Watchlist]

Comment on attachment 337962 [details]
patch for landing

Attachment 337962 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7317590

New failing tests:
stress/function-caller-async-function-body.js.default

[Filip Pizlo]

Created attachment 337972 [details]
patch for landing

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/230662/webkit

[Radar WebKit Bug Importer]

<rdar://problem/39443234>