Bug 184623 - [GTK][WPE] Build is broken after r230640
Summary: [GTK][WPE] Build is broken after r230640
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 21:07 PDT by Carlos Bentzen
Modified: 2018-04-14 00:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2018-04-13 21:13 PDT, Carlos Bentzen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Bentzen 2018-04-13 21:07:40 PDT
In the linking stage of MiniBrowser:

/home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::SuspendedPageProxy(WebKit::WebPageProxy&, WebKit::WebProcessProxy&, WebKit::WebBackForwardListItem&)'
/home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::loggingString() const'
/home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::webProcessDidClose(WebKit::WebProcessProxy&)'
/home/cadubentzen/git/github/webkit/WebKitBuild/gtk/Debug/lib/libwebkit2gtk-4.0.so: undefined reference to `WebKit::SuspendedPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)'

Because SuspendedPageProxy.h is included in WebProcessProxy.cpp but SuspendedPageProxy.cpp is not compiled via the CMake build.
Comment 1 Carlos Bentzen 2018-04-13 21:13:51 PDT
Created attachment 337957 [details]
Patch
Comment 2 WebKit Commit Bot 2018-04-14 00:00:59 PDT
Comment on attachment 337957 [details]
Patch

Clearing flags on attachment: 337957

Committed r230657: <https://trac.webkit.org/changeset/230657>
Comment 3 WebKit Commit Bot 2018-04-14 00:01:01 PDT
All reviewed patches have been landed.  Closing bug.