Bug 184598 - [JSC] Use {resolve,reject,promise} instead of {@resolve,@reject,@promise}
Summary: [JSC] Use {resolve,reject,promise} instead of {@resolve,@reject,@promise}
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 10:45 PDT by Yusuke Suzuki
Modified: 2021-11-01 12:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (51.88 KB, patch)
2018-04-13 10:49 PDT, Yusuke Suzuki 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-04-13 10:45:51 PDT 
[JSC] Use {resolve,reject,promise} instead of {@resolve,@reject,@promise}
Comment 1 Yusuke Suzuki 2018-04-13 10:49:10 PDT 
Created attachment 337907 [details]
Patch
Comment 2 EWS Watchlist 2018-04-13 12:19:07 PDT 
Comment on attachment 337907 [details]
Patch

Attachment 337907 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7307694

New failing tests:
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager
Comment 3 Yusuke Suzuki 2018-04-13 13:01:37 PDT 
(In reply to Build Bot from comment #2)
> Comment on attachment 337907 [details]
> Patch
> 
> Attachment 337907 [details] did not pass jsc-ews (mac):
> Output: http://webkit-queues.webkit.org/results/7307694
> 
> New failing tests:
> stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager

It is flaky test, and it’s not related to this patch.
Comment 4 Yusuke Suzuki 2018-04-19 06:15:02 PDT 
Ping?
Comment 5 Yusuke Suzuki 2018-04-30 09:45:24 PDT 
Ping review?
Comment 6 Yusuke Suzuki 2018-05-05 19:50:08 PDT 
Ping?
Comment 7 Saam Barati 2018-07-20 11:48:23 PDT 
Comment on attachment 337907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337907&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        We know that promise capabilities object has these own properties.
> +        So we do not need to use private names for these properties. This
> +        change reduces the usage of private named properties in our builtin
> +        JS, and only internal properties and special private properties (like,
> +        @charCodeAt) uses @xxx names.

What's the benefit here? Seems better to err on the side of being more conservative.
Comment 8 Alex Christensen 2021-11-01 12:04:28 PDT 
Comment on attachment 337907 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.