Bug 184595 – [WPE] [webkitpy] The driver requirements should be checked before starting the tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Alberto Lopez Perez]

Currently the WPE port doesn't call the driver check_driver() method.

So, what happens when the user tries to run layout tests with the wayland driver, from a non wayland environment you get all crashes.

Instead, the user should get a meaningful error saying that she should use wayland

[Carlos Alberto Lopez Perez]

Created attachment 337901 [details]
Patch

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #1)
> Created attachment 337901 [details]
> Patch

after this patch, trying to run layout tests on wpe from a non-wayland environment will result in:

18:52:19.121 3274 wptwk successfully started (pid = 3372)
18:52:19.121 3274 
18:52:19.121 3274 Running 29948 tests
18:52:19.121 3274 
18:52:19.121 3274 Checking build ...
18:52:19.215 3274 "Tools/Scripts/build-dumprendertree --release --wpe" took 0.09s
18:52:19.215 3274 Output of ['Tools/Scripts/build-dumprendertree', '--release', '--wpe']:
18:52:19.287 3274 "Tools/Scripts/build-webkittestrunner --release --wpe" took 0.07s
18:52:19.287 3274 Output of ['Tools/Scripts/build-webkittestrunner', '--release', '--wpe']:
18:52:19.288 3274 Starting helper ...
18:52:19.548 3274 Checking system dependencies ...
18:52:19.581 3274 "/usr/sbin/apache2 -v" took 0.03s
18:52:19.581 3274 WAYLAND_DISPLAY or WAYLAND_SOCKET not found in the environment. Cannot run tests.
18:52:19.582 3274 Testing completed, Exit status: -1
18:52:19.583 3274 Stopping Web Platform Test server ...
No handlers could be found for logger "webkitpy.layout_tests.servers.http_server_base"



... instead of thousands of crashes.

[Carlos Alberto Lopez Perez]

Comment on attachment 337901 [details]
Patch

Clearing flags on attachment: 337901

Committed r230653: <https://trac.webkit.org/changeset/230653>

[Carlos Alberto Lopez Perez]

All reviewed patches have been landed.  Closing bug.