Bug 184581 – [GTK][GStreamer] Tests crashing since playbin3 was added

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Claudio Saavedra]

These tests started crashing with r230540. They were already failing but now they crash.

http/tests/media/hls/hls-audio-tracks-locale-selection.html
http/tests/media/hls/hls-progress.html
http/tests/media/hls/video-controller-getStartDate.html

[Claudio Saavedra]

Maybe this can help (pretty much the same for all three):

Thread 1 (Thread 0x7f6f38332ac0 (LWP 7836)):
#0  _g_log_abort () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:554
#1  0x00007f6f3fcf4415 in g_logv () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1362
#2  0x00007f6f3fcf4562 in g_log () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1403
#3  0x00007f6f47fd3a17 in _ZN7WebCore25TrackPrivateBaseGStreamer10disconnectEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#4  0x00007f6f47fd3ad7 in _ZN7WebCore25TrackPrivateBaseGStreamerD2Ev () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#5  0x00007f6f47fd2059 in _ZN7WebCore26AudioTrackPrivateGStreamerD0Ev () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#6  0x00007f6f47df2bf3 in _ZN7WebCore10AudioTrackD2Ev () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#7  0x00007f6f47df2cb9 in _ZN7WebCore10AudioTrackD0Ev () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#8  0x00007f6f47dfddef in _ZN7WebCore10TrackEventD2Ev () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#9  0x00007f6f47dfde09 in _ZN7WebCore10TrackEventD0Ev () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#10 0x00007f6f4734e5fa in _ZN7WebCore17GenericEventQueue16dispatchOneEventEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#11 0x00007f6f477f778c in _ZN7WebCore14TaskDispatcherINS_5TimerEE15dispatchOneTaskEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#12 0x00007f6f477f7897 in _ZN7WebCore14TaskDispatcherINS_5TimerEE16sharedTimerFiredEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#13 0x00007f6f4782318a in _ZN7WebCore12ThreadTimers24sharedTimerFiredInternalEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#14 0x00007f6f4468a793 in _ZZN3WTF7RunLoop9TimerBaseC4ERS0_ENUlPvE_4_FUNES3_ () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#15 0x00007f6f3fced81a in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148
#16 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813
#17 0x00007f6f3fcedba8 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886
#18 0x00007f6f3fcedec2 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082
#19 0x00007f6f4468abb0 in _ZN3WTF7RunLoop3runEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#20 0x00007f6f46ada7c2 in _ZN6WebKit16ChildProcessMainINS_10WebProcessENS_14WebProcessMainEEEiiPPc () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#21 0x00007f6f3dd2c2b1 in __libc_start_main (main=0x7f6f497e7cb0 <main>, argc=3, argv=0x7fff0fe8df38, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff0fe8df28) at ../csu/libc-start.c:291
#22 0x00007f6f497e7d3a in _start ()

STDERR: 
STDERR: warning: core file may not match specified executable file.
STDERR: 
STDERR: (WebKitWebProcess:7836): GStreamer-CRITICAL **: gst_object_unref: assertion '((GObject *) object)->ref_count > 0' failed

[Philippe Normand]

Strange though, playbin3 isn't enabled unless the USE_PLAYBIN3 env var is set.

[Thibault Saunier]

(In reply to Philippe Normand from comment #2)
> Strange though, playbin3 isn't enabled unless the USE_PLAYBIN3 env var is
> set.

Right, the probleme seem to be that now the playbin3 support is built (as Gst > 1.10), I think we enter that code path:

```
#if GST_CHECK_VERSION(1, 10, 0)
    if (m_stream)
        m_stream.clear();
#endif
```

in `void TrackPrivateBaseGStreamer::disconnect()`, but m_stream should bu NULL here.

I have not been able to reproduce locally.

[Claudio Saavedra]

I can reproduce this crash locally so if you need me to try any patch I can do it.

[Thibault Saunier]

(In reply to Claudio Saavedra from comment #4)
> I can reproduce this crash locally so if you need me to try any patch I can
> do it.
Is it racy?

[Philippe Normand]

Have you tried with GStreamer 1.10 or 1.14, Thibault?

[Thibault Saunier]

Created attachment 340020 [details]
[GStreamer] Never call updateTracks if running on legacy pipeline

[Philippe Normand]

Comment on attachment 340020 [details]
[GStreamer] Never call updateTracks if running on legacy pipeline

View in context: https://bugs.webkit.org/attachment.cgi?id=340020&action=review

Which element is sending the message?

> Source/WebCore/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Duplicate :)

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1288
> +        if (!m_isLegacyPlaybin) {

Please turn this to an early break

[Thibault Saunier]

Created attachment 340023 [details]
[GStreamer] Never call updateTracks if running on legacy pipeline

[Thibault Saunier]

(In reply to Philippe Normand from comment #8)
> Comment on attachment 340020 [details]
> [GStreamer] Never call updateTracks if running on legacy pipeline
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340020&action=review
> 
> Which element is sending the message?
> 
> > Source/WebCore/ChangeLog:10
> > +        Reviewed by NOBODY (OOPS!).
> 
> Duplicate :)

Fixed.


> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1288
> > +        if (!m_isLegacyPlaybin) {
> 
> Please turn this to an early break

Done.

[Philippe Normand]

(In reply to Thibault Saunier from comment #10)
> (In reply to Philippe Normand from comment #8)
> > Comment on attachment 340020 [details]
> > [GStreamer] Never call updateTracks if running on legacy pipeline
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=340020&action=review
> > 
> > Which element is sending the message?

And this ^^ :)

[Thibault Saunier]

(In reply to Philippe Normand from comment #11)
> (In reply to Thibault Saunier from comment #10)
> > (In reply to Philippe Normand from comment #8)
> > > Comment on attachment 340020 [details]
> > > [GStreamer] Never call updateTracks if running on legacy pipeline
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=340020&action=review
> > > 
> > > Which element is sending the message?
> 
> And this ^^ :)

Oops, missed that question... I didn't check directly but it must be tsdemux, the only demuxers who knows how to post stream collections afaik.

[Philippe Normand]

wow ok, tsdemux lives in the future already!

[Philippe Normand]

Comment on attachment 340023 [details]
[GStreamer] Never call updateTracks if running on legacy pipeline

View in context: https://bugs.webkit.org/attachment.cgi?id=340023&action=review

> LayoutTests/ChangeLog:3
> +        [GStreamer] Never call updateTracks if running on legacy pipeline

Ah sorry I missed this. This line should always be the bug title. So you could have either moved the explanation below or retitled the bug. For future reference anyway, this is jus a nit.

[WebKit Commit Bot]

Comment on attachment 340023 [details]
[GStreamer] Never call updateTracks if running on legacy pipeline

Clearing flags on attachment: 340023

Committed r231600: <https://trac.webkit.org/changeset/231600>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

*** Bug 185252 has been marked as a duplicate of this bug. ***