Bug 184570 – REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list

• Status: RESOLVED
• Resolution: FIXED
• Component: History

[Sihui Liu]

If device is not connected to the internet, pressing reload button will add item to the history list.

[Sihui Liu]

<rdar://problem/34807323>

[Sihui Liu]

Created attachment 337989 [details]
Patch

[Chris Dumez]

Comment on attachment 337989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337989&action=review

r=me with nit fixes.

> Source/WebCore/loader/FrameLoader.cpp:1443
> +    } else if (shouldTreatURLAsSameAsCurrent(newDocumentLoader->unreachableURL()) && (m_loadType == FrameLoadType::Reload || m_loadType == FrameLoadType::ReloadExpiredOnly || m_loadType == FrameLoadType::ReloadFromOrigin))

There is a isReload(FrameLoadType) utility function that does what you want.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:139
> +        NSURL* targetURL = WebCore::URLWithData([NSData dataWithBytes:literal length:strlen(literal)], nil);

I would suggest:
NSURL *invalidURL = [NSURL URLWithString:@"https://www.example.com<>/"];

And dropping your literal variable.

[Sihui Liu]

Created attachment 338222 [details]
Patch

[Sihui Liu]

Created attachment 338223 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 338223 [details]
Patch

Clearing flags on attachment: 338223

Committed r230767: <https://trac.webkit.org/changeset/230767>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.