Bug 184559 - Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one
Summary: Introduce SuspendedPageProxy to keep old web processes around after their Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-12 15:36 PDT by Brady Eidson
Modified: 2018-04-13 11:05 PDT (History)
10 users (show)

See Also:

Attachments
Patch (48.87 KB, patch)
2018-04-12 15:54 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (48.84 KB, patch)
2018-04-12 16:19 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (48.81 KB, patch)
2018-04-12 16:34 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (48.86 KB, patch)
2018-04-13 10:23 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (49.00 KB, patch)
2018-04-13 10:31 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-04-12 15:36:14 PDT 
Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one

This is an intermediate step towards:
1 - Keeping the page cache working
2 - Keeping an origin-keyed process pool around, ready to reuse.
Comment 1 Brady Eidson 2018-04-12 15:54:45 PDT Comment hidden (obsolete)
Comment 2 Brady Eidson 2018-04-12 16:19:17 PDT Comment hidden (obsolete)
Comment 3 Brady Eidson 2018-04-12 16:34:47 PDT 
Created attachment 337850 [details]
Patch
Comment 4 Alex Christensen 2018-04-13 08:09:54 PDT 
Comment on attachment 337850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337850&action=review

> Source/WebCore/loader/DocumentLoader.cpp:659
> +        completionHandler(WTFMove(newRequest));

At this point completionHandler has been moved into navigationPolicyCompletionHandler, right?

> Source/WebCore/loader/FrameLoader.cpp:3234
> +    WTF::Function<void(void)> completionHandler = [this, shouldContinue] {

WTF can be removed.
This should probably also be a CompletionHandler.
Comment 5 Brady Eidson 2018-04-13 10:23:51 PDT 
Created attachment 337904 [details]
Patch
Comment 6 Brady Eidson 2018-04-13 10:31:06 PDT 
Created attachment 337906 [details]
Patch
Comment 7 WebKit Commit Bot 2018-04-13 11:04:28 PDT 
Comment on attachment 337906 [details]
Patch

Clearing flags on attachment: 337906

Committed r230640: <https://trac.webkit.org/changeset/230640>
Comment 8 WebKit Commit Bot 2018-04-13 11:04:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-04-13 11:05:21 PDT 
<rdar://problem/39417321>