Bug 184541 - [Web Animations] Suspend animations when required
Summary: [Web Animations] Suspend animations when required
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-12 08:41 PDT by Antoine Quint
Modified: 2018-04-12 10:39 PDT (History)
8 users (show)

See Also:

Attachments
Patch (24.76 KB, patch)
2018-04-12 08:50 PDT, Antoine Quint 		jonlee: review+
jonlee: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.14 MB, application/zip)
2018-04-12 10:14 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.19 MB, application/zip)
2018-04-12 10:29 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-04-12 08:41:13 PDT 
[Web Animations] Suspend animations when required
Comment 1 Antoine Quint 2018-04-12 08:50:28 PDT 
Created attachment 337800 [details]
Patch
Comment 2 Jon Lee 2018-04-12 09:40:10 PDT 
Comment on attachment 337800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337800&action=review

> Source/WebCore/ChangeLog:19
> +        (WebCore::DocumentTimeline::numberOfActiveAnimations const): Called by Internals::numberOfActiveAnimations(), this

I think we tend to name functions specific for internals with the "ForTesting" suffix. so: numberOfActiveAnimationsForTesting; to prevent accidental use by real code.
Comment 3 Antoine Quint 2018-04-12 09:47:41 PDT 
(In reply to Jon Lee from comment #2)
> Comment on attachment 337800 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337800&action=review
> 
> > Source/WebCore/ChangeLog:19
> > +        (WebCore::DocumentTimeline::numberOfActiveAnimations const): Called by Internals::numberOfActiveAnimations(), this
> 
> I think we tend to name functions specific for internals with the
> "ForTesting" suffix. so: numberOfActiveAnimationsForTesting; to prevent
> accidental use by real code.

Cool! I'll make that change.
Comment 4 EWS Watchlist 2018-04-12 10:14:16 PDT 
Comment on attachment 337800 [details]
Patch

Attachment 337800 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7294996

New failing tests:
animations/added-while-suspended.html
transitions/created-while-suspended.html
Comment 5 EWS Watchlist 2018-04-12 10:14:18 PDT 
Created attachment 337805 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-04-12 10:29:12 PDT 
Comment on attachment 337800 [details]
Patch

Attachment 337800 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7295005

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 7 EWS Watchlist 2018-04-12 10:29:13 PDT 
Created attachment 337807 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 8 Antoine Quint 2018-04-12 10:38:07 PDT 
Committed r230581: <https://trac.webkit.org/changeset/230581>
Comment 9 Radar WebKit Bug Importer 2018-04-12 10:39:25 PDT 
<rdar://problem/39385844>