RESOLVED FIXED 184539
[Web Animations] Ensure elements overlapping with elements animating also get composited 
https://bugs.webkit.org/show_bug.cgi?id=184539
Summary [Web Animations] Ensure elements overlapping with elements animating also get...
Antoine Quint
Reported 2018-04-12 08:25:25 PDT
[Web Animations] Ensure elements overlapping with elements animating also get composited
Attachments
Patch (26.94 KB, patch)
2018-04-12 08:32 PDT, Antoine Quint 		jonlee: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-04-12 08:32:45 PDT
Created attachment 337797 [details] Patch
Jon Lee
Comment 2 2018-04-12 09:28:40 PDT
Comment on attachment 337797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337797&action=review > Source/WebCore/animation/DocumentTimeline.h:62 > + // transform animation but we were unable to cheaply compute its affect on the extent. effect*
Antoine Quint
Comment 3 2018-04-12 09:34:50 PDT
Committed r230578: <https://trac.webkit.org/changeset/230578>
Radar WebKit Bug Importer
Comment 4 2018-04-12 09:35:20 PDT
<rdar://problem/39383567>
Ryan Haddad
Comment 5 2018-04-12 10:12:35 PDT
(In reply to Antoine Quint from comment #3) > Committed r230578: <https://trac.webkit.org/changeset/230578> This change broke the Windows build: c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\animation\documenttimeline.cpp(208): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\animation\documenttimeline.cpp(208): warning C4701: potentially uninitialized local variable 'matchingEffect' used [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\animation\documenttimeline.cpp(208): warning C4703: potentially uninitialized local pointer variable 'matchingEffect' used [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/8766
Antoine Quint
Comment 6 2018-04-12 10:42:07 PDT
Windows build should be fixed by https://trac.webkit.org/changeset/230582.
Note You need to log in before you can comment on or make changes to this bug.