Bug 184534 – [WPE] Fix --display-server=weston to spawn the server

• Status: NEW
• Component: New Bugs

[Xabier Rodríguez Calvar]

[WPE] Fix --display-server=weston to spawn the server

[Xabier Rodríguez Calvar]

Created attachment 337790 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 337790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337790&action=review

> Tools/Scripts/webkitpy/port/wpe.py:73
> -        return WaylandDriver
> +        if self._display_server == "weston":
> +            return WestonDriver
> +        if self._display_server == "wayland":
> +            return WaylandDriver

Please keep the wayland driver as default (when no option is passed)

[Xabier Rodríguez Calvar]

(In reply to Carlos Alberto Lopez Perez from comment #2)
> > Tools/Scripts/webkitpy/port/wpe.py:73
> > -        return WaylandDriver
> > +        if self._display_server == "weston":
> > +            return WestonDriver
> > +        if self._display_server == "wayland":
> > +            return WaylandDriver
> 
> Please keep the wayland driver as default (when no option is passed)

Can I fix this during landing?

[Carlos Garcia Campos]

(In reply to Xabier Rodríguez Calvar from comment #3)
> (In reply to Carlos Alberto Lopez Perez from comment #2)
> > > Tools/Scripts/webkitpy/port/wpe.py:73
> > > -        return WaylandDriver
> > > +        if self._display_server == "weston":
> > > +            return WestonDriver
> > > +        if self._display_server == "wayland":
> > > +            return WaylandDriver
> > 
> > Please keep the wayland driver as default (when no option is passed)
> 
> Can I fix this during landing?

I don't think this is the only problem of this patch. I still don't understand how the weston driver can work in WPE in its current state. WPE requires accelerated compositing and EGL, but weston is launched with --use-pixman by the weston driver. I would expect that to crash WPE. I think we should change weston driver a bit to be able to use it in WPE. It also requires xwayland, since it's running weston inside xvfb.