Bug 184524 - [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
Summary: [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency tree / graph
 
Reported: 2018-04-11 19:14 PDT by Fujii Hironori
Modified: 2018-04-17 18:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.41 KB, patch)
2018-04-11 19:17 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch to land (18.46 KB, patch)
2018-04-16 21:23 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-04-11 19:14:09 PDT 
[WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit

It was removed in Bug 104607.
Comment 1 Fujii Hironori 2018-04-11 19:17:47 PDT 
Created attachment 337769 [details]
Patch
Comment 2 Fujii Hironori 2018-04-13 21:17:06 PDT 
Could anyone review?
Comment 3 Alex Christensen 2018-04-16 08:42:23 PDT 
Comment on attachment 337769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38
> +    constexpr size_t bufferLength = _MAX_PATH * 4;

This seems excessive.

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53
> +    String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension);

This seems specific to a certain build configuration.
Comment 4 Fujii Hironori 2018-04-16 21:16:48 PDT 
Comment on attachment 337769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review

Thank you for the review.

>> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38
>> +    constexpr size_t bufferLength = _MAX_PATH * 4;
> 
> This seems excessive.

Agreed. I'll use _MAX_PATH+1.

>> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53
>> +    String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension);
> 
> This seems specific to a certain build configuration.

Mac port is copying the resource file into the build directory.
GTK and WPE ports are using a env var to specify the source directory.
Old WebKit port was using the same approach with Mac port.
I'm going to solve this problem in another bug.
Comment 5 Fujii Hironori 2018-04-16 21:23:05 PDT 
Created attachment 338077 [details]
Patch to land
Comment 6 Fujii Hironori 2018-04-17 18:01:37 PDT 
Committed r230744: <https://trac.webkit.org/changeset/230744>
Comment 7 Radar WebKit Bug Importer 2018-04-17 18:03:22 PDT 
<rdar://problem/39512612>
Comment 8 Fujii Hironori 2018-04-17 18:08:52 PDT 
(In reply to Fujii Hironori from comment #4)
> I'm going to solve this problem in another bug.

Filed Bug 184722.