NEW 184519
JSC should have a mode where it does runtime checks to validate clobberize() 
https://bugs.webkit.org/show_bug.cgi?id=184519
Summary JSC should have a mode where it does runtime checks to validate clobberize()
Filip Pizlo
Reported 2018-04-11 17:01:51 PDT
Patch forthcoming.
Attachments
it begins (22.89 KB, patch)
2018-04-11 17:02 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
I wrote things (64.34 KB, patch)
2018-04-12 11:48 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
starting to compile (67.48 KB, patch)
2018-04-12 13:55 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it ran 3d-cube! (68.58 KB, patch)
2018-04-12 15:54 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
maybe the patch (78.46 KB, patch)
2018-04-12 19:15 PDT, Filip Pizlo 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-sierra (1.50 MB, application/zip)
2018-04-12 20:43 PDT, EWS Watchlist 		no flags
Details
more (83.17 KB, patch)
2018-04-12 20:45 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-04-11 17:02:17 PDT
Created attachment 337753 [details] it begins
Filip Pizlo
Comment 2 2018-04-12 11:48:03 PDT
Created attachment 337816 [details] I wrote things
Filip Pizlo
Comment 3 2018-04-12 13:55:01 PDT
Created attachment 337833 [details] starting to compile
Filip Pizlo
Comment 4 2018-04-12 15:54:09 PDT
Created attachment 337843 [details] it ran 3d-cube!
Filip Pizlo
Comment 5 2018-04-12 19:15:38 PDT
Created attachment 337856 [details] maybe the patch
Filip Pizlo
Comment 6 2018-04-12 19:15:55 PDT
Comment on attachment 337856 [details] maybe the patch it's not really ready for review.
EWS Watchlist
Comment 7 2018-04-12 19:18:45 PDT
Attachment 337856 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/ClobberAsserts.cpp:71: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/ClobberAsserts.h:47: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/runtime/ClobberAsserts.h:57: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/JavaScriptCore/runtime/JSCell.h:138: The parameter name "vm" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/JSCell.h:138: The parameter name "id" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 8 2018-04-12 20:43:16 PDT
Comment on attachment 337856 [details] maybe the patch Attachment 337856 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7300622 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 9 2018-04-12 20:43:18 PDT
Created attachment 337861 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Filip Pizlo
Comment 10 2018-04-12 20:45:26 PDT
Created attachment 337862 [details] more
Note You need to log in before you can comment on or make changes to this bug.