Bug 184518 – [Web Animations] Enable seeking for hardware animations

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

[Web Animations] Enable seeking for hardware animations

[Antoine Quint]

Created attachment 337751 [details]
Patch

[Antoine Quint]

Created attachment 337777 [details]
Patch

[Dean Jackson]

Comment on attachment 337777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337777&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2806
> +            const String& currAnimationName = it->key;
> +            AnimationsMap::iterator animationIt = m_runningAnimations.find(currAnimationName);

Nit: Just say currentAnimationName and animationIterator

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2813
> +                for (size_t i = 0; i < animations.size(); ++i) {
> +                    const LayerPropertyAnimation& currAnimation = animations[i];

Can't this be a for (const auto& currentAnimation : animations) loop?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2950
> +    RefPtr<PlatformCAAnimation> curAnim = layer->animationForKey(animationID);

Again, just say currentAnimation. Or at least be consistent - above is currAnimation, this is curAnim.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2955
> +    RefPtr<PlatformCAAnimation> newAnim = curAnim->copy();

Ditto.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:531
> +        Seconds timeOffset; // only used for pause

Nit: // Only used for pause. (uppercase O and period)

[Antoine Quint]

Committed r230574: <https://trac.webkit.org/changeset/230574>

[Radar WebKit Bug Importer]

<rdar://problem/39381530>

[Antoine Quint]

This caused https://bugs.webkit.org/show_bug.cgi?id=185299.