RESOLVED FIXED 184518
[Web Animations] Enable seeking for hardware animations
https://bugs.webkit.org/show_bug.cgi?id=184518
Summary [Web Animations] Enable seeking for hardware animations
Antoine Quint
Reported 2018-04-11 16:33:34 PDT
[Web Animations] Enable seeking for hardware animations
Attachments
Patch (54.18 KB, patch)
2018-04-11 16:53 PDT, Antoine Quint
no flags
Patch (54.19 KB, patch)
2018-04-12 00:18 PDT, Antoine Quint
dino: review+
Antoine Quint
Comment 1 2018-04-11 16:53:09 PDT
Antoine Quint
Comment 2 2018-04-12 00:18:21 PDT
Dean Jackson
Comment 3 2018-04-12 04:10:05 PDT
Comment on attachment 337777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337777&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2806 > + const String& currAnimationName = it->key; > + AnimationsMap::iterator animationIt = m_runningAnimations.find(currAnimationName); Nit: Just say currentAnimationName and animationIterator > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2813 > + for (size_t i = 0; i < animations.size(); ++i) { > + const LayerPropertyAnimation& currAnimation = animations[i]; Can't this be a for (const auto& currentAnimation : animations) loop? > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2950 > + RefPtr<PlatformCAAnimation> curAnim = layer->animationForKey(animationID); Again, just say currentAnimation. Or at least be consistent - above is currAnimation, this is curAnim. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2955 > + RefPtr<PlatformCAAnimation> newAnim = curAnim->copy(); Ditto. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:531 > + Seconds timeOffset; // only used for pause Nit: // Only used for pause. (uppercase O and period)
Antoine Quint
Comment 4 2018-04-12 08:14:39 PDT
Radar WebKit Bug Importer
Comment 5 2018-04-12 08:15:30 PDT
Antoine Quint
Comment 6 2018-05-04 06:55:32 PDT
Note You need to log in before you can comment on or make changes to this bug.