Add support for converting a local window to a remote window.
<rdar://problem/39011318>
Created attachment 337734 [details] WIP Patch
Attachment 337734 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:185: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 75 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 337735 [details] WIP Patch
Attachment 337735 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:185: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 337737 [details] WIP Patch
Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7287980 Number of test failures exceeded the failure limit.
Created attachment 337740 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7287941 Number of test failures exceeded the failure limit.
Created attachment 337742 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7287988 New failing tests: http/tests/navigation/process-swap-window-open.html
Created attachment 337744 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7288005 New failing tests: http/tests/navigation/process-swap-window-open.html
Created attachment 337749 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 337825 [details] WIP Patch
Created attachment 337830 [details] WIP Patch
Comment on attachment 337830 [details] WIP Patch Attachment 337830 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7297793 Number of test failures exceeded the failure limit.
Created attachment 337837 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337830 [details] WIP Patch Attachment 337830 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7297779 Number of test failures exceeded the failure limit.
Created attachment 337839 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 337863 [details] WIP Patch
Comment on attachment 337863 [details] WIP Patch Attachment 337863 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7301517 Number of test failures exceeded the failure limit.
Created attachment 337865 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337863 [details] WIP Patch Attachment 337863 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7301512 Number of test failures exceeded the failure limit.
Created attachment 337866 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337863 [details] WIP Patch Attachment 337863 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7301546 New failing tests: media/video-frame-accurate-seek.html
Created attachment 337867 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 337917 [details] WIP Patch
Created attachment 337919 [details] WIP Patch
Created attachment 337926 [details] WIP Patch
Created attachment 337931 [details] WIP Patch
Created attachment 337979 [details] WIP Patch
Created attachment 338029 [details] WIP Patch
Created attachment 338130 [details] WIP Patch
Created attachment 338144 [details] Patch
Comment on attachment 338144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338144&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:2441 > + m_mainFrameWindowCreationHandler = [this, previousProcess = WTFMove(previousProcess), previousFrameIdentifier = *previousFrameIdentifier](const GlobalWindowIdentifier& windowIdentifier) { I think it's clearer to call previousProcess as frameOwnerProcess and ownerFrameIdentifier, etc.. since what's important here is that it's the process/frame which opened this frame.
Comment on attachment 338144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338144&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:2441 >> + m_mainFrameWindowCreationHandler = [this, previousProcess = WTFMove(previousProcess), previousFrameIdentifier = *previousFrameIdentifier](const GlobalWindowIdentifier& windowIdentifier) { > > I think it's clearer to call previousProcess as frameOwnerProcess and ownerFrameIdentifier, etc.. > since what's important here is that it's the process/frame which opened this frame. This is not accurate. This is the identifier of the frame that is about to become remote in the old process. This is not the identifier of the frame which opened the new window. I guess the naming needs clarifying either way.
Created attachment 338221 [details] Patch
Comment on attachment 338221 [details] Patch Clearing flags on attachment: 338221 Committed r230764: <https://trac.webkit.org/changeset/230764>
All reviewed patches have been landed. Closing bug.