Bug 184508 - Fix TestInvocation class for newer versions of clang
Summary: Fix TestInvocation class for newer versions of clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-11 10:22 PDT by Jonathan Bedard
Modified: 2018-04-11 13:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2018-04-11 10:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.22 KB, patch)
2018-04-11 13:19 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-04-11 10:22:42 PDT 
Newer versions of clang raise a warning when compiling the TestInvocation class because it is not declared as final and does not have a virtual destructor.
Comment 1 Jonathan Bedard 2018-04-11 10:24:33 PDT 
Created attachment 337710 [details]
Patch
Comment 2 Alexey Proskuryakov 2018-04-11 12:54:01 PDT 
rdar://problem/39328648
Comment 3 Jonathan Bedard 2018-04-11 13:19:30 PDT 
Created attachment 337727 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-04-11 13:38:28 PDT 
Comment on attachment 337727 [details]
Patch for landing

Clearing flags on attachment: 337727

Committed r230545: <https://trac.webkit.org/changeset/230545>
Comment 5 WebKit Commit Bot 2018-04-11 13:38:29 PDT 
All reviewed patches have been landed.  Closing bug.