Bug 184507 - pemfile.py should not assume POSIX line endings
Summary: pemfile.py should not assume POSIX line endings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-11 09:59 PDT by Ross Kirsling
Modified: 2018-04-12 13:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2018-04-11 10:00 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2018-04-11 10:16 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2018-04-11 10:40 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (1.60 KB, patch)
2018-04-12 13:07 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (2.39 KB, patch)
2018-04-12 13:09 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-04-11 09:59:42 PDT 
pemfile.py should not assume POSIX line endings
Comment 1 Ross Kirsling 2018-04-11 10:00:56 PDT 
Created attachment 337708 [details]
Patch
Comment 2 Ross Kirsling 2018-04-11 10:16:23 PDT 
Created attachment 337709 [details]
Patch
Comment 3 Daniel Bates 2018-04-11 10:22:23 PDT 
Comment on attachment 337709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337709&action=review

> Tools/Scripts/webkitpy/common/system/pemfile.py:101
> +    lines = re.split("\r?\n", content)

Please add a unit test for this change.
Comment 4 Ross Kirsling 2018-04-11 10:40:54 PDT 
Created attachment 337712 [details]
Patch
Comment 5 Daniel Bates 2018-04-12 11:27:47 PDT 
Comment on attachment 337712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337712&action=review

r=me

> Tools/Scripts/webkitpy/common/system/pemfile.py:101
> +    lines = re.split('\r?\n', content)

Could the PEM file ever contain only carriage returns (\r)?
Comment 6 Ross Kirsling 2018-04-12 13:07:38 PDT 
Created attachment 337826 [details]
Patch for landing
Comment 7 Ross Kirsling 2018-04-12 13:09:14 PDT 
Created attachment 337827 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-04-12 13:48:15 PDT 
Comment on attachment 337827 [details]
Patch for landing

Clearing flags on attachment: 337827

Committed r230593: <https://trac.webkit.org/changeset/230593>
Comment 9 WebKit Commit Bot 2018-04-12 13:48:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-12 13:49:19 PDT 
<rdar://problem/39392571>