Bug 184498 - [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
Summary: [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-11 07:30 PDT by Thibault Saunier
Modified: 2019-04-16 07:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (18.34 KB, patch)
2018-04-11 07:31 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (18.97 KB, patch)
2018-04-11 10:57 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (18.97 KB, patch)
2018-04-11 10:59 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-04-11 07:30:11 PDT 
[GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
Comment 1 Thibault Saunier 2018-04-11 07:31:30 PDT 
Created attachment 337699 [details]
Patch
Comment 2 Philippe Normand 2018-04-11 07:45:03 PDT 
Comment on attachment 337699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337699&action=review

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:24
> +#include <gst/gst.h>

This is for GST_CHECK_VERSION(), right? Then please remove the now useless forward typedefs :)

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2402
> +void MediaPlayerPrivateGStreamer::createGSTPlayBin(const gchar *playbin_name)

Please use camelCase :P
Comment 3 Philippe Normand 2018-04-11 07:48:49 PDT 
Comment on attachment 337699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337699&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2402
>> +void MediaPlayerPrivateGStreamer::createGSTPlayBin(const gchar *playbin_name)
> 
> Please use camelCase :P

Ah also, we use char instead of gchar usually, and the star is mispositioned. Not sure why check-webkit-style didn't complain there...
Comment 4 Thibault Saunier 2018-04-11 10:57:49 PDT 
Created attachment 337714 [details]
Patch
Comment 5 Thibault Saunier 2018-04-11 10:59:10 PDT 
Created attachment 337715 [details]
Patch
Comment 6 Thibault Saunier 2018-04-11 11:01:03 PDT 
> Ah also, we use char instead of gchar usually, and the star is mispositioned. Not sure why check-webkit-style didn't complain there...

From my small checks, we do using g<ctypes> quite a lot all around :-) Looks like the star positioning is not enforce anywhere in the webkit style (clang-format doesn't seem to care, and the script doesn't either)
Comment 7 Thibault Saunier 2018-04-11 11:01:28 PDT 
(I fixed it all anyway)
Comment 8 WebKit Commit Bot 2018-04-11 11:33:44 PDT 
Comment on attachment 337715 [details]
Patch

Clearing flags on attachment: 337715

Committed r230540: <https://trac.webkit.org/changeset/230540>
Comment 9 WebKit Commit Bot 2018-04-11 11:33:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-11 11:34:21 PDT 
<rdar://problem/39354946>
Comment 11 Michael Catanzaro 2019-04-16 07:36:35 PDT 
Please, environment variables need to be documented at https://trac.webkit.org/wiki/EnvironmentVariables