Bug 184483 - Don't have selections get stuck in editable elements
Summary: Don't have selections get stuck in editable elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-10 20:23 PDT by Megan Gardner
Modified: 2018-04-12 11:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2018-04-10 20:27 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-04-10 20:23:34 PDT 
Don't have selections get stuck in editable elements
Comment 1 Megan Gardner 2018-04-10 20:27:09 PDT 
Created attachment 337671 [details]
Patch
Comment 2 Megan Gardner 2018-04-10 20:27:43 PDT 
<rdar://problem/35189283>
Comment 3 Sam Weinig 2018-04-10 22:27:11 PDT 
Is this something that can be tested?
Comment 4 Timothy Hatcher 2018-04-11 07:40:59 PDT 
Comment on attachment 337671 [details]
Patch

Same comment as Sam. Maybe testing can be done with an API test?
Comment 5 Sam Weinig 2018-04-11 13:27:02 PDT 
Or a new test type that dumps selection state/info?
Comment 6 Megan Gardner 2018-04-12 11:23:57 PDT 
The selection tests don't seem to be working right in content editable. I will investigate this soon and add some tests later.
Comment 7 WebKit Commit Bot 2018-04-12 11:50:38 PDT 
Comment on attachment 337671 [details]
Patch

Clearing flags on attachment: 337671

Committed r230588: <https://trac.webkit.org/changeset/230588>
Comment 8 WebKit Commit Bot 2018-04-12 11:50:40 PDT 
All reviewed patches have been landed.  Closing bug.