Use more r-values in NetworkResourceLoader
Created attachment 337661 [details] Patch
Created attachment 337662 [details] Patch
Comment on attachment 337662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337662&action=review r=me with comment. > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:178 > + m_cache->retrieve(request, { m_parameters.webPageID, m_parameters.webFrameID }, [this, loader = WTFMove(loader), request = ResourceRequest { request }](auto entry) mutable { This was already capturing by value, I do not understand why the explicit "= ResourceRequest { request }" would be needed.
Thanks for the review. > This was already capturing by value, I do not understand why the explicit "= > ResourceRequest { request }" would be needed. I had a compilation error if not doing so. I believe request is captured as a "const ResourceRequest" otherwise.
(In reply to youenn fablet from comment #4) > Thanks for the review. > > > This was already capturing by value, I do not understand why the explicit "= > > ResourceRequest { request }" would be needed. > > I had a compilation error if not doing so. > I believe request is captured as a "const ResourceRequest" otherwise. And you sure you had the "mutable" at the time? Still seems odd.
Comment on attachment 337662 [details] Patch Clearing flags on attachment: 337662 Committed r230528: <https://trac.webkit.org/changeset/230528>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39350780>