Bug 184478 – Use more r-values in NetworkResourceLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Use more r-values in NetworkResourceLoader

[youenn fablet]

Created attachment 337661 [details]
Patch

[youenn fablet]

Created attachment 337662 [details]
Patch

[Chris Dumez]

Comment on attachment 337662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337662&action=review

r=me with comment.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:178
> +    m_cache->retrieve(request, { m_parameters.webPageID, m_parameters.webFrameID }, [this, loader = WTFMove(loader), request = ResourceRequest { request }](auto entry) mutable {

This was already capturing by value, I do not understand why the explicit "= ResourceRequest { request }" would be needed.

[youenn fablet]

Thanks for the review.

> This was already capturing by value, I do not understand why the explicit "=
> ResourceRequest { request }" would be needed.

I had a compilation error if not doing so.
I believe request is captured as a "const ResourceRequest" otherwise.

[Chris Dumez]

(In reply to youenn fablet from comment #4)
> Thanks for the review.
> 
> > This was already capturing by value, I do not understand why the explicit "=
> > ResourceRequest { request }" would be needed.
> 
> I had a compilation error if not doing so.
> I believe request is captured as a "const ResourceRequest" otherwise.

And you sure you had the "mutable" at the time? Still seems odd.

[WebKit Commit Bot]

Comment on attachment 337662 [details]
Patch

Clearing flags on attachment: 337662

Committed r230528: <https://trac.webkit.org/changeset/230528>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39350780>