Bug 184476 – REGRESSION (r230326?): Layout Test http/tests/contentextensions/make-https.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

The following layout test is flaky on High Sierra

http/tests/contentextensions/make-https.html

Probable cause:

Unknown, this flakiness started within the last 5 days.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcontentextensions%2Fmake-https.html

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/contentextensions/make-https-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/contentextensions/make-https-actual.txt
@@ -6,7 +6,7 @@
 http://127.0.0.1/nope - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -1004, failing URL "http://127.0.0.1/nope">
 CONSOLE MESSAGE: line 30: Content blocker promoted URL from http://127.0.0.1/promote to https
 https://127.0.0.1/promote - willSendRequest <NSURLRequest URL https://127.0.0.1/promote, main document URL http://127.0.0.1:8000/contentextensions/make-https.html, http method GET> redirectResponse (null)
-https://127.0.0.1/promote - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -1200, failing URL "https://127.0.0.1/promote">
+https://127.0.0.1/promote - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -1004, failing URL "https://127.0.0.1/promote">
 CONSOLE MESSAGE: line 30: Content blocker promoted URL from http://127.0.0.1/promote to https
 https://127.0.0.1/promote - willSendRequest <NSURLRequest URL https://127.0.0.1/promote, main document URL http://127.0.0.1:8000/contentextensions/make-https.html, http method GET> redirectResponse (null)
 https://127.0.0.1/promote - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -1200, failing URL "https://127.0.0.1/promote">

[Ryan Haddad]

This may have started after https://trac.webkit.org/changeset/230326/webkit

[Radar WebKit Bug Importer]

<rdar://problem/39384226>

[Ryan Haddad]

Marked test as flaky in https://trac.webkit.org/r231364

[youenn fablet]

-1004 probably means it cannot connect to the host and -1200 that there was an SSL error which can be both legitimate errors in this context.
I don't think my change did anything there.
Looking at the history of this test, there was some rebasing to go from -1004 to -1200.

Looking at the test itself, it does not really need to dump all the load callbacks.
The four console log message lines cover the fact that the loads are upgraded to https.

[youenn fablet]

Created attachment 339583 [details]
Patch

[EWS Watchlist]

Comment on attachment 339583 [details]
Patch

Attachment 339583 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7567987

New failing tests:
http/tests/contentextensions/make-https.html

[EWS Watchlist]

Created attachment 339590 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 339593 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339593 [details]
Patch

Clearing flags on attachment: 339593

Committed r231388: <https://trac.webkit.org/changeset/231388>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.