That summary isn't the most clear. Will attach a test case. In short, if I set a prototype property in an outer window and then grab an object from that type from a frame, that property shouldn't be set on the object from the frame. This is how Firefox and Opera work.
Created attachment 20495 [details] Shows that CSSStyleDeclaration and String behave differently.
This no longer occurs in Safari 5.0.1. Not sure if we need to land a test for this.
Ugh, didn't mean to close the bug. Probably worth committing a test for this.
Created attachment 67488 [details] Patch
Comment on attachment 67488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67488&action=prettypatch > LayoutTests/fast/frames/frame-prototype-inheritance.html:11 > + // alert(win.CSSStyleDeclaration.prototype.foo); Please remove commented out code.
Created attachment 67502 [details] Patch
Comment on attachment 67502 [details] Patch Did you mean to set cq?
Comment on attachment 67502 [details] Patch Rejecting patch 67502 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20991 test cases. fast/css/visited-link-hang.html -> failed Exiting early after 1 failures. 6198 tests run. 131.28s total testing time 6197 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/4059011
> Rejecting patch 67502 from commit-queue. We just change some core logic in the commit-queue. Not sure if we have a bug now.
Comment on attachment 67502 [details] Patch Clearing flags on attachment: 67502 Committed r67511: <http://trac.webkit.org/changeset/67511>
All reviewed patches have been landed. Closing bug.