Avoid constructing a service worker RegistrationStore from private sessions since there is no need for persistence and the registrationDatabaseDirectory is the empty string in such cases.
<rdar://problem/36613948>
Created attachment 337627 [details] Patch
Comment on attachment 337627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337627&action=review > Source/WebCore/workers/service/server/SWServer.h:231 > + std::unique_ptr<RegistrationStore> m_registrationStore; Might be able to forward-declare RegistrationStore now?
Created attachment 337645 [details] Patch
Comment on attachment 337645 [details] Patch Clearing flags on attachment: 337645 Committed r230500: <https://trac.webkit.org/changeset/230500>
All reviewed patches have been landed. Closing bug.
Comment on attachment 337645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337645&action=review > Source/WebCore/workers/service/server/SWServerWorker.h:30 > +#include "ContentSecurityPolicyResponseHeaders.h" Is it necessary to includ this header? > Source/WebKit/StorageProcess/StorageProcess.cpp:197 > + if (!parameters.indexedDatabaseDirectory.isEmpty()) How is this change related to the related to this bug? > Source/WebKit/StorageProcess/StorageProcess.cpp:210 > + if (!parameters.serviceWorkerRegistrationDirectory.isEmpty()) Ditto.
(In reply to Daniel Bates from comment #7) > Comment on attachment 337645 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337645&action=review > > > Source/WebCore/workers/service/server/SWServerWorker.h:30 > > +#include "ContentSecurityPolicyResponseHeaders.h" > > Is it necessary to includ this header? Is it necessary to include this header? > > > Source/WebKit/StorageProcess/StorageProcess.cpp:197 > > + if (!parameters.indexedDatabaseDirectory.isEmpty()) > > How is this change related to the related to this bug? Never mind. > > > Source/WebKit/StorageProcess/StorageProcess.cpp:210 > > + if (!parameters.serviceWorkerRegistrationDirectory.isEmpty()) > > Ditto. Never mind.
Comment on attachment 337645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337645&action=review >>> Source/WebCore/workers/service/server/SWServerWorker.h:30 >>> +#include "ContentSecurityPolicyResponseHeaders.h" >> >> Is it necessary to includ this header? > > Is it necessary to include this header? Yes due to the following data member in this class: ContentSecurityPolicyResponseHeaders m_contentSecurityPolicy;