Bug 184438 - [Win] Add UserAgentWin.cpp
Summary: [Win] Add UserAgentWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency treegraph
 
Reported: 2018-04-09 21:45 PDT by Fujii Hironori
Modified: 2018-04-10 18:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2018-04-09 21:49 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch to land (5.29 KB, patch)
2018-04-10 18:20 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-04-09 21:45:04 PDT
[Win] Add UserAgentWin.cpp

UserAgentWin.cpp is needed to implement WebPageProxy::standardUserAgent and WebPage::platformUserAgent.
Comment 1 Fujii Hironori 2018-04-09 21:49:19 PDT
Created attachment 337586 [details]
Patch
Comment 2 Michael Catanzaro 2018-04-10 12:58:33 PDT
Comment on attachment 337586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337586&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (No behavior change).

It's definitely a behavior change, right? You have a user agent now where you did not before.

> Source/WebCore/platform/win/UserAgentWin.cpp:55
> +    return String();

return { }
Comment 3 Fujii Hironori 2018-04-10 18:09:27 PDT
Comment on attachment 337586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337586&action=review

Thank you for the review.

>> Source/WebCore/ChangeLog:8
>> +        No new tests (No behavior change).
> 
> It's definitely a behavior change, right? You have a user agent now where you did not before.

WebPageProxyWin.cpp is not upstreamed yet. This patch changes nothing at the moment.
In the futre, WebKit2 for Windows port and WebKitTestRunner for Windows port will be finished to implement.
Existing test case http/tests/navigation/useragent.php will covers this change.
Comment 4 Fujii Hironori 2018-04-10 18:20:25 PDT
Created attachment 337666 [details]
Patch to land
Comment 5 Fujii Hironori 2018-04-10 18:53:09 PDT
Committed r230509: <https://trac.webkit.org/changeset/230509>
Comment 6 Radar WebKit Bug Importer 2018-04-10 18:54:31 PDT
<rdar://problem/39334514>