WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184438
[Win] Add UserAgentWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=184438
Summary
[Win] Add UserAgentWin.cpp
Fujii Hironori
Reported
2018-04-09 21:45:04 PDT
[Win] Add UserAgentWin.cpp UserAgentWin.cpp is needed to implement WebPageProxy::standardUserAgent and WebPage::platformUserAgent.
Attachments
Patch
(5.20 KB, patch)
2018-04-09 21:49 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
Patch to land
(5.29 KB, patch)
2018-04-10 18:20 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2018-04-09 21:49:19 PDT
Created
attachment 337586
[details]
Patch
Michael Catanzaro
Comment 2
2018-04-10 12:58:33 PDT
Comment on
attachment 337586
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=337586&action=review
> Source/WebCore/ChangeLog:8 > + No new tests (No behavior change).
It's definitely a behavior change, right? You have a user agent now where you did not before.
> Source/WebCore/platform/win/UserAgentWin.cpp:55 > + return String();
return { }
Fujii Hironori
Comment 3
2018-04-10 18:09:27 PDT
Comment on
attachment 337586
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=337586&action=review
Thank you for the review.
>> Source/WebCore/ChangeLog:8 >> + No new tests (No behavior change). > > It's definitely a behavior change, right? You have a user agent now where you did not before.
WebPageProxyWin.cpp is not upstreamed yet. This patch changes nothing at the moment. In the futre, WebKit2 for Windows port and WebKitTestRunner for Windows port will be finished to implement. Existing test case http/tests/navigation/useragent.php will covers this change.
Fujii Hironori
Comment 4
2018-04-10 18:20:25 PDT
Created
attachment 337666
[details]
Patch to land
Fujii Hironori
Comment 5
2018-04-10 18:53:09 PDT
Committed
r230509
: <
https://trac.webkit.org/changeset/230509
>
Radar WebKit Bug Importer
Comment 6
2018-04-10 18:54:31 PDT
<
rdar://problem/39334514
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug