Bug 184427 - webrtc/datachannel/bufferedAmountLowThreshold tests are failing on WK1
Summary: webrtc/datachannel/bufferedAmountLowThreshold tests are failing on WK1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-09 13:40 PDT by youenn fablet
Modified: 2018-04-10 14:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2018-04-09 13:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.97 KB, patch)
2018-04-09 15:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-04-09 13:40:46 PDT 
webrtc/datachannel/bufferedAmountLowThreshold tests are failing on WK1
Comment 1 youenn fablet 2018-04-09 13:43:10 PDT 
Created attachment 337537 [details]
Patch
Comment 2 Eric Carlson 2018-04-09 14:02:59 PDT 
Comment on attachment 337537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337537&action=review

> LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html:26
> -for (var cptr = 0; cptr < 14; ++cptr)
> +for (var cptr = 0; cptr < 10; ++cptr)

A comment in the ChangeLog about why this fixes the test could be helpful to someone looking at this in the future.
Comment 3 youenn fablet 2018-04-09 15:15:15 PDT 
Created attachment 337551 [details]
Patch
Comment 4 WebKit Commit Bot 2018-04-10 14:14:01 PDT 
Comment on attachment 337551 [details]
Patch

Clearing flags on attachment: 337551

Committed r230493: <https://trac.webkit.org/changeset/230493>
Comment 5 WebKit Commit Bot 2018-04-10 14:14:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-04-10 14:15:32 PDT 
<rdar://problem/39326506>