Bug 184426 – Add support for setting a background color on WKWebView and WKView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Timothy Hatcher]

WebView has long had support for setting a background color. WKWebView and WKView should support the same too.

<rdar://problem/39132633>

[Timothy Hatcher]

Created attachment 337543 [details]
Patch

[Megan Gardner]

Comment on attachment 337543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337543&action=review

R=Me, but you need a real review

> Tools/TestWebKitAPI/Tests/mac/BackgroundColor.mm:110
> +

How about a test that just sets the color to something specific, like Purple. I know the systemColor one basically does that, but it depends the on the control stuff being right.

[Wenson Hsieh]

Comment on attachment 337543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337543&action=review

LGTM! You might need a WK2 owner to review, though.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:263
> +@property (nonatomic, setter=_setBackgroundColor:) NSColor *_backgroundColor;

Nit - we usually make copyable non-POD properties copy.

[Beth Dakin]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 337543 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337543&action=review
> 
> LGTM! You might need a WK2 owner to review, though.
> 

rs=me on top of Wenson's review for WK2 owner stamp.

> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:263
> > +@property (nonatomic, setter=_setBackgroundColor:) NSColor *_backgroundColor;
> 
> Nit - we usually make copyable non-POD properties copy.

[WebKit Commit Bot]

Comment on attachment 337543 [details]
Patch

Clearing flags on attachment: 337543

Committed r230462: <https://trac.webkit.org/changeset/230462>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Comment on attachment 337543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337543&action=review

>>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:263
>>> +@property (nonatomic, setter=_setBackgroundColor:) NSColor *_backgroundColor;
>> 
>> Nit - we usually make copyable non-POD properties copy.
> 
> 

This declaration is missing availability information.

[Wenson Hsieh]

Reopening to attach new patch.

[Wenson Hsieh]

Created attachment 337583 [details]
Add missing availability

[Timothy Hatcher]

Comment on attachment 337583 [details]
Add missing availability

Thanks! You beat me to it.

[EWS Watchlist]

Comment on attachment 337583 [details]
Add missing availability

Attachment 337583 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7263363

New failing tests:
imported/w3c/web-platform-tests/workers/name-property.html

[EWS Watchlist]

Created attachment 337588 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Wenson Hsieh]

(In reply to Build Bot from comment #11)
> Comment on attachment 337583 [details]
> Add missing availability
> 
> Attachment 337583 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/7263363
> 
> New failing tests:
> imported/w3c/web-platform-tests/workers/name-property.html

...pretty certain this is unrelated.

Landed directly on trunk in r230470.