Bug 184424 – Expand WebCore policy concept of "shouldContinue" to allow for more than true/false

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Expand WebCore policy concept of "shouldContinue" to allow for more than true/false

Specifically:
-Yes
-No
-ForSuspension

[Brady Eidson]

Created attachment 337525 [details]
Patch

[Brady Eidson]

Created attachment 337536 [details]
Patch

[Alex Christensen]

Comment on attachment 337536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337536&action=review

> Source/WebCore/loader/FrameLoader.cpp:3186
> +        FALLTHROUGH;

I don't think this FALLTHROUGH is necessary here or above.
I also think this whole thing could be just shouldContinue != ShouldContinue::No

> Source/WebCore/loader/PolicyChecker.h:60
> +using NavigationPolicyDecisionFunction = WTF::CompletionHandler<void(ResourceRequest&&, FormState*, ShouldContinue)>;

WTF:: could be removed.

[Brady Eidson]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 337536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337536&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:3186
> > +        FALLTHROUGH;
> 
> I don't think this FALLTHROUGH is necessary here or above.
> I also think this whole thing could be just shouldContinue !=
> ShouldContinue::No

But I want to make sure all cases are always accounted for even if new ones are addddeddddddd!!!!


> 
> > Source/WebCore/loader/PolicyChecker.h:60
> > +using NavigationPolicyDecisionFunction = WTF::CompletionHandler<void(ResourceRequest&&, FormState*, ShouldContinue)>;
> 
> WTF:: could be removed.

Sure

[Alex Christensen]

Comment on attachment 337536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337536&action=review

> Source/WebCore/loader/FrameLoader.cpp:3190
> +    case ShouldContinue::ForSuspension:
> +        shouldContinueBool = true;
> +    case ShouldContinue::No:
> +        shouldContinueBool = false;

Give me a break!

[Brady Eidson]

Created attachment 337554 [details]
Patch

[Brady Eidson]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 337536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337536&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:3190
> > +    case ShouldContinue::ForSuspension:
> > +        shouldContinueBool = true;
> > +    case ShouldContinue::No:
> > +        shouldContinueBool = false;
> 
> Give me a break!

No!

(Okay maybe)

[Brady Eidson]

Created attachment 337557 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 337557 [details]
Patch

Clearing flags on attachment: 337557

Committed r230458: <https://trac.webkit.org/changeset/230458>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39299789>