Bug 184423 - Fix the selection assistant selectionView build
Summary: Fix the selection assistant selectionView build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-09 11:55 PDT by Jer Noble
Modified: 2018-04-09 12:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2018-04-09 11:58 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (3.04 KB, patch)
2018-04-09 12:18 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-04-09 11:55:08 PDT 
Fix the selection assistant selectionView build
Comment 1 Radar WebKit Bug Importer 2018-04-09 11:55:56 PDT 
<rdar://problem/39288235>
Comment 2 Jer Noble 2018-04-09 11:58:11 PDT 
Created attachment 337516 [details]
Patch
Comment 3 Wenson Hsieh 2018-04-09 12:07:37 PDT 
Comment on attachment 337516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337516&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
>          [[_webSelectionAssistant selectionView] setHidden:NO];

You might want to consider guarding the declaration of the selectionView property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.
Comment 4 Jer Noble 2018-04-09 12:10:27 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 337516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337516&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
> >          [[_webSelectionAssistant selectionView] setHidden:NO];
> 
> You might want to consider guarding the declaration of the selectionView
> property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.

Will do.
Comment 5 Jer Noble 2018-04-09 12:18:28 PDT 
Created attachment 337522 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-04-09 12:58:22 PDT 
Comment on attachment 337522 [details]
Patch for landing

Clearing flags on attachment: 337522

Committed r230448: <https://trac.webkit.org/changeset/230448>
Comment 7 WebKit Commit Bot 2018-04-09 12:58:23 PDT 
All reviewed patches have been landed.  Closing bug.