Bug 184423 – Fix the selection assistant selectionView build

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Fix the selection assistant selectionView build

[Radar WebKit Bug Importer]

<rdar://problem/39288235>

[Jer Noble]

Created attachment 337516 [details]
Patch

[Wenson Hsieh]

Comment on attachment 337516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337516&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
>          [[_webSelectionAssistant selectionView] setHidden:NO];

You might want to consider guarding the declaration of the selectionView property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.

[Jer Noble]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 337516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337516&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
> >          [[_webSelectionAssistant selectionView] setHidden:NO];
> 
> You might want to consider guarding the declaration of the selectionView
> property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.

Will do.

[Jer Noble]

Created attachment 337522 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 337522 [details]
Patch for landing

Clearing flags on attachment: 337522

Committed r230448: <https://trac.webkit.org/changeset/230448>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.