Bug 184420 - [Web Animations] Duplicate layout tests exercising CSS Animations and CSS Transitions in a dedicated legacy directory
Summary: [Web Animations] Duplicate layout tests exercising CSS Animations and CSS Tra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-09 10:59 PDT by Antoine Quint
Modified: 2018-06-03 19:29 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.62 MB, patch)
2018-04-09 11:01 PDT, Antoine Quint
dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.32 MB, application/zip)
2018-04-09 12:28 PDT, EWS Watchlist
no flags Details
Patch (8.62 MB, patch)
2018-04-09 12:45 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.05 MB, application/zip)
2018-04-09 12:50 PDT, EWS Watchlist
no flags Details
Patch (8.62 MB, patch)
2018-04-09 13:06 PDT, Antoine Quint
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.76 MB, application/zip)
2018-04-09 15:05 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (2.95 MB, application/zip)
2018-04-09 15:11 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews204 for win-future (13.14 MB, application/zip)
2018-04-09 22:27 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-04-09 10:59:23 PDT
[Web Animations] Duplicate layout tests exercising CSS Animations and CSS Transitions in dedicated legacy directories
Comment 1 Antoine Quint 2018-04-09 11:01:47 PDT
Created attachment 337511 [details]
Patch
Comment 2 Dean Jackson 2018-04-09 11:45:41 PDT
Are those new top level directories? Could you make a single new top-level, and then put everything under that?
Comment 3 Dean Jackson 2018-04-09 11:46:10 PDT
Comment on attachment 337511 [details]
Patch

rs=me
Comment 4 EWS Watchlist 2018-04-09 12:28:00 PDT
Comment on attachment 337511 [details]
Patch

Attachment 337511 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7255733

New failing tests:
legacy-animation-engine-animations/font-variations/font-variation-settings-unlike.html
legacy-animation-engine-animations/font-variations/font-style.html
legacy-animation-engine-animations/font-variations/font-variation-settings.html
legacy-animation-engine-animations/font-variations/font-stretch.html
legacy-animation-engine-animations/font-variations/font-variation-settings-order.html
Comment 5 EWS Watchlist 2018-04-09 12:28:02 PDT
Created attachment 337524 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Antoine Quint 2018-04-09 12:30:27 PDT
(In reply to Dean Jackson from comment #2)
> Are those new top level directories? Could you make a single new top-level,
> and then put everything under that?

That was my original plan, but it required a significant amount of extra work to rewrite all resource paths in the test files.
Comment 7 Antoine Quint 2018-04-09 12:45:37 PDT
Created attachment 337528 [details]
Patch
Comment 8 EWS Watchlist 2018-04-09 12:50:12 PDT
Comment on attachment 337511 [details]
Patch

Attachment 337511 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7255944

New failing tests:
legacy-animation-engine-animations/font-variations/font-variation-settings-unlike.html
legacy-animation-engine-animations/font-variations/font-style.html
legacy-animation-engine-animations/font-variations/font-variation-settings.html
legacy-animation-engine-animations/font-variations/font-stretch.html
legacy-animation-engine-animations/font-variations/font-variation-settings-order.html
Comment 9 EWS Watchlist 2018-04-09 12:50:13 PDT
Created attachment 337530 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 10 Antoine Quint 2018-04-09 13:03:15 PDT
(In reply to Antoine Quint from comment #6)
> (In reply to Dean Jackson from comment #2)
> > Are those new top level directories? Could you make a single new top-level,
> > and then put everything under that?
> 
> That was my original plan, but it required a significant amount of extra
> work to rewrite all resource paths in the test files.

Actually, it's not that hard, filing a new patch soon with a single top-level directory.
Comment 11 Antoine Quint 2018-04-09 13:06:44 PDT
Created attachment 337531 [details]
Patch
Comment 12 EWS Watchlist 2018-04-09 15:05:36 PDT
Comment on attachment 337531 [details]
Patch

Attachment 337531 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7257719

New failing tests:
imported/w3c/web-platform-tests/workers/name-property.html
Comment 13 EWS Watchlist 2018-04-09 15:05:38 PDT
Created attachment 337547 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 14 EWS Watchlist 2018-04-09 15:11:57 PDT
Comment on attachment 337531 [details]
Patch

Attachment 337531 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7257338

New failing tests:
imported/w3c/web-platform-tests/workers/name-property.html
Comment 15 EWS Watchlist 2018-04-09 15:11:58 PDT
Created attachment 337550 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 16 EWS Watchlist 2018-04-09 22:27:32 PDT
Comment on attachment 337531 [details]
Patch

Attachment 337531 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7263303

New failing tests:
legacy-animation-engine/compositing/animation/animation-backing.html
legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html
legacy-animation-engine/compositing/visible-rect/animated.html
legacy-animation-engine/compositing/layer-creation/scale-rotation-animation-overlap.html
legacy-animation-engine/compositing/layer-creation/overlap-animation.html
legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html
legacy-animation-engine/compositing/layer-creation/mismatched-transform-transition-overlap.html
legacy-animation-engine/css3/filters/backdrop/animation.html
legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap.html
legacy-animation-engine/compositing/contents-scale/animating.html
legacy-animation-engine/compositing/layer-creation/overlap-animation-container.html
legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html
legacy-animation-engine/compositing/geometry/limit-layer-bounds-opacity-transition.html
legacy-animation-engine/fullscreen/fullscreen-auto-hide-delay.html
legacy-animation-engine/compositing/layer-creation/multiple-keyframes-animation-overlap.html
legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html
legacy-animation-engine/compositing/reflections/load-video-in-reflection.html
legacy-animation-engine/compositing/visible-rect/animated-from-none.html
legacy-animation-engine/compositing/backing/backface-visibility-flip.html
legacy-animation-engine/compositing/animation/animation-compositing.html
legacy-animation-engine/compositing/layer-creation/translate-animation-overlap.html
legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap.html
legacy-animation-engine/compositing/layer-creation/scale-rotation-transition-overlap.html
legacy-animation-engine/compositing/layer-creation/overlap-animation-clipping.html
Comment 17 EWS Watchlist 2018-04-09 22:27:44 PDT
Created attachment 337590 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 18 Antoine Quint 2018-04-09 22:42:23 PDT
Committed r230471: <https://trac.webkit.org/changeset/230471>
Comment 19 Radar WebKit Bug Importer 2018-04-09 22:45:33 PDT
<rdar://problem/39305781>