Bug 184415 - Change Event's returnValue so it doesn't expose a new primitive
Summary: Change Event's returnValue so it doesn't expose a new primitive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#dom-even...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-09 04:34 PDT by Anne van Kesteren
Modified: 2018-04-15 18:03 PDT (History)
14 users (show)

See Also:


Attachments
Patch (45.78 KB, patch)
2018-04-13 14:16 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (46.92 KB, patch)
2018-04-13 15:00 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.67 MB, application/zip)
2018-04-13 16:55 PDT, EWS Watchlist
no flags Details
Patch (45.63 KB, patch)
2018-04-15 17:17 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Chris Dumez 2018-04-13 14:16:02 PDT
Created attachment 337923 [details]
Patch
Comment 2 Chris Dumez 2018-04-13 15:00:11 PDT
Created attachment 337925 [details]
Patch
Comment 3 EWS Watchlist 2018-04-13 16:55:35 PDT
Comment on attachment 337925 [details]
Patch

Attachment 337925 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7310054

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-04-13 16:55:46 PDT
Created attachment 337932 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Chris Dumez 2018-04-13 16:59:54 PDT
Comment on attachment 337925 [details]
Patch

Windows failure looks unrelated.
Comment 6 Darin Adler 2018-04-15 12:01:33 PDT
Comment on attachment 337925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337925&action=review

> Source/WebCore/dom/Event.h:99
> +    WEBCORE_EXPORT void setLegacyReturnValue(bool);

Why less inlining? I would have left everything in the header and marked inline.
Comment 7 Chris Dumez 2018-04-15 17:17:25 PDT
Created attachment 337985 [details]
Patch
Comment 8 WebKit Commit Bot 2018-04-15 18:01:24 PDT
Comment on attachment 337985 [details]
Patch

Clearing flags on attachment: 337985

Committed r230664: <https://trac.webkit.org/changeset/230664>
Comment 9 WebKit Commit Bot 2018-04-15 18:01:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-15 18:03:26 PDT
<rdar://problem/39445537>