Bug 184415 – Change Event's returnValue so it doesn't expose a new primitive

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

See https://github.com/whatwg/dom/pull/626 and https://github.com/w3c/web-platform-tests/pull/10258.

[Chris Dumez]

Created attachment 337923 [details]
Patch

[Chris Dumez]

Created attachment 337925 [details]
Patch

[EWS Watchlist]

Comment on attachment 337925 [details]
Patch

Attachment 337925 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7310054

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 337932 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Chris Dumez]

Comment on attachment 337925 [details]
Patch

Windows failure looks unrelated.

[Darin Adler]

Comment on attachment 337925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337925&action=review

> Source/WebCore/dom/Event.h:99
> +    WEBCORE_EXPORT void setLegacyReturnValue(bool);

Why less inlining? I would have left everything in the header and marked inline.

[Chris Dumez]

Created attachment 337985 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 337985 [details]
Patch

Clearing flags on attachment: 337985

Committed r230664: <https://trac.webkit.org/changeset/230664>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39445537>