CRASH() should call abort() except on Darwin and in developer builds, as discussed at https://lists.webkit.org/pipermail/webkit-dev/2018-March/029903.html. This should be slightly nicer than dereferencing 0xbadbeef. On Darwin, CRASH() uses a breakpoint trap, which seems to corrupt the stack on Linux, so we can't do that. Continue to call WTFCrash() in developer mode, and make no changes to WTFCrash(), since it is reportedly useful in nightmare scenarios where core dumps are unavailable: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029907.html
Created attachment 337478 [details] Patch
Comment on attachment 337478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337478&action=review > Source/WTF/wtf/Assertions.h:234 > +#elif !ENABLE(DEVELOPER_MODE) && !OS(DARWIN) Note that I don't check NDEBUG here specifically in order to allow Adrian to use WTFCrash() in "release" builds.
Pinging GTK/WPE reviewers.
(In reply to Michael Catanzaro from comment #0) > CRASH() should call abort() except on Darwin and in developer builds, as > discussed at > https://lists.webkit.org/pipermail/webkit-dev/2018-March/029903.html. This > should be slightly nicer than dereferencing 0xbadbeef. Ping any reviewers.
Comment on attachment 337478 [details] Patch OK
Comment on attachment 337478 [details] Patch Clearing flags on attachment: 337478 Committed r238469: <https://trac.webkit.org/changeset/238469>
All reviewed patches have been landed. Closing bug.
<rdar://problem/46228007>
Reverted r238469 for reason: Broke the build Committed r238477: <https://trac.webkit.org/changeset/238477>
Created attachment 355596 [details] Patch
Comment on attachment 355596 [details] Patch Clearing flags on attachment: 355596 Committed r238478: <https://trac.webkit.org/changeset/238478>