Bug 184407 - [GTK] check target looks broken
Summary: [GTK] check target looks broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-08 20:19 PDT by Michael Catanzaro
Modified: 2018-04-23 18:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2018-04-09 09:24 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-04-08 20:19:12 PDT 
I see in Source/PlatformGTK.cmake:

add_custom_target(check
    COMMAND ${TOOLS_DIR}/Scripts/run-gtk-tests
    COMMAND ${TOOLS_DIR}/gtk/check-for-webkitdom-api-breaks
)

But we got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating the DOM API. So that probably does not work.
Comment 1 Michael Catanzaro 2018-04-09 09:24:00 PDT 
Created attachment 337500 [details]
Patch
Comment 2 WebKit Commit Bot 2018-04-23 18:08:02 PDT 
Comment on attachment 337500 [details]
Patch

Clearing flags on attachment: 337500

Committed r230937: <https://trac.webkit.org/changeset/230937>
Comment 3 WebKit Commit Bot 2018-04-23 18:08:04 PDT 
All reviewed patches have been landed.  Closing bug.