Bug 184405 – [WPE][GTK] Remove WlUniquePtr<wl_display> footgun

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Michael Catanzaro]

WlUniquePtr<wl_display> is a pretty big footgun because there are two different destruction functions -- wl_display_disconnect() and wl_display_destroy() -- and which one you need to use depends on how the wl_display() was created, and WebKit uses both in different places. So WlUniquePtr<wl_display> is pretty unsafe. See bug #176490 for an example of fun caused by using it incorrectly.

Let's use std::unique_ptr with custom deleter functors instead. Suggestions for how to do this better (without giving up RAII) are quite welcome.

[Michael Catanzaro]

Created attachment 337474 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 337474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337474&action=review

> Source/WebKit/UIProcess/gtk/WaylandCompositor.h:129
> +        void operator() (struct wl_display* display) { wl_display_destroy(display); }

const

[Michael Catanzaro]

Comment on attachment 337474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337474&action=review

>> Source/WebKit/UIProcess/gtk/WaylandCompositor.h:129
>> +        void operator() (struct wl_display* display) { wl_display_destroy(display); }
> 
> const

const seems pretty overkill for a function object with no member variables :)

[WebKit Commit Bot]

Comment on attachment 337474 [details]
Patch

Clearing flags on attachment: 337474

Committed r230936: <https://trac.webkit.org/changeset/230936>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39668727>