Bug 184402 - [iOS] WKContentView and WKLegacyPDFView should share application state tracking logic
Summary: [iOS] WKContentView and WKLegacyPDFView should share application state tracki...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-08 13:54 PDT by Andy Estes
Modified: 2018-04-08 18:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch (22.64 KB, patch)
2018-04-08 14:00 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (22.65 KB, patch)
2018-04-08 17:53 PDT, Andy Estes 		aestes: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-04-08 13:54:17 PDT 
[iOS] WKContentView and WKLegacyPDFView should share application state tracking logic
Comment 1 Andy Estes 2018-04-08 14:00:59 PDT 
Created attachment 337464 [details]
Patch
Comment 2 mitz 2018-04-08 15:26:03 PDT 
Comment on attachment 337464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337464&action=review

> Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm:38
> +using namespace WebCore;
> +using namespace WebKit;

I thought we were moving away from doing this in modern WebKit.
Comment 3 Andy Estes 2018-04-08 16:01:47 PDT 
(In reply to mitz from comment #2)
> Comment on attachment 337464 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337464&action=review
> 
> > Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm:38
> > +using namespace WebCore;
> > +using namespace WebKit;
> 
> I thought we were moving away from doing this in modern WebKit.

Oh, ok. Maybe it makes unifying sources more difficult? I'll get rid of them.

Thanks for reviewing!
Comment 4 Andy Estes 2018-04-08 17:53:14 PDT 
Created attachment 337471 [details]
Patch
Comment 5 Andy Estes 2018-04-08 18:48:36 PDT 
Committed r230383: <https://trac.webkit.org/changeset/230383>
Comment 6 Radar WebKit Bug Importer 2018-04-08 18:49:20 PDT 
<rdar://problem/39269308>