Bug 184395 – Add pointer profiling to the FTL and supporting code.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Radar WebKit Bug Importer]

<rdar://problem/39264019>

[Mark Lam]

Created attachment 337452 [details]
proposed patch.

Let's get some EWS testing.

[Mark Lam]

Created attachment 337454 [details]
proposed patch.

[Michael Saboff]

Comment on attachment 337454 [details]
proposed patch.

r=me

[Filip Pizlo]

Comment on attachment 337454 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=337454&action=review

> Source/JavaScriptCore/ftl/FTLOutput.h:408
> -    LValue operation(FunctionType function) { return constIntPtr(bitwise_cast<void*>(function)); }
> +    LValue operation(FunctionType function) { return constIntPtr(tagCFunctionPtr<void*>(function, B3CCallPtrTag)); }

Ideally we would support passing more specific diversity to B3::CCall.  Can you file a bug and reference it here with a FIXME?

I totally see how it's not necessary for making this feature work right now, but such a FIXME will help us remember that it's only this way because it was expedient.

[Filip Pizlo]

(In reply to Michael Saboff from comment #4)
> Comment on attachment 337454 [details]
> proposed patch.
> 
> r=me

r=me too

[Mark Lam]

(In reply to Filip Pizlo from comment #5)
> Comment on attachment 337454 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337454&action=review
> 
> > Source/JavaScriptCore/ftl/FTLOutput.h:408
> > -    LValue operation(FunctionType function) { return constIntPtr(bitwise_cast<void*>(function)); }
> > +    LValue operation(FunctionType function) { return constIntPtr(tagCFunctionPtr<void*>(function, B3CCallPtrTag)); }
> 
> Ideally we would support passing more specific diversity to B3::CCall.  Can
> you file a bug and reference it here with a FIXME?
> 
> I totally see how it's not necessary for making this feature work right now,
> but such a FIXME will help us remember that it's only this way because it
> was expedient.

Done.  Ref: https://bugs.webkit.org/show_bug.cgi?id=184324

[Mark Lam]

Thanks for the reviews.  Landed in r230444: <http://trac.webkit.org/r230444>.