WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184373
MediaSessionManageriOS should defer creation of MPVolumeView until it needs to monitor AirPlay routes
https://bugs.webkit.org/show_bug.cgi?id=184373
Summary
MediaSessionManageriOS should defer creation of MPVolumeView until it needs t...
Jeremy Jones
Reported
2018-04-06 16:21:01 PDT
MediaSessionManageriOS should defer creation of MPVolumeView until it needs to monitor AirPlay routes
Attachments
Patch
(10.15 KB, patch)
2018-04-06 16:30 PDT
,
Jeremy Jones
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(9.91 KB, patch)
2018-04-09 10:04 PDT
,
Jeremy Jones
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Jones
Comment 1
2018-04-06 16:29:15 PDT
rdar://problem/35177606
Jeremy Jones
Comment 2
2018-04-06 16:30:12 PDT
Created
attachment 337402
[details]
Patch
Eric Carlson
Comment 3
2018-04-06 19:56:59 PDT
Comment on
attachment 337402
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=337402&action=review
> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:429 > + BEGIN_BLOCK_OBJC_EXCEPTIONS > + [routingController setDiscoveryMode:MPRouteDiscoveryModeDisabled]; > + volumeView.clear(); > + routingController.clear(); > + END_BLOCK_OBJC_EXCEPTIONS
This is the same as the block in -dealloc, can they be shared?
Jeremy Jones
Comment 4
2018-04-09 09:44:41 PDT
(In reply to Eric Carlson from
comment #3
)
> Comment on
attachment 337402
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=337402&action=review
> > > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:429 > > + BEGIN_BLOCK_OBJC_EXCEPTIONS > > + [routingController setDiscoveryMode:MPRouteDiscoveryModeDisabled]; > > + volumeView.clear(); > > + routingController.clear(); > > + END_BLOCK_OBJC_EXCEPTIONS > > This is the same as the block in -dealloc, can they be shared?
I can actually share it in three places.
Jeremy Jones
Comment 5
2018-04-09 10:04:56 PDT
Created
attachment 337506
[details]
Patch for landing
WebKit Commit Bot
Comment 6
2018-04-10 13:31:07 PDT
Comment on
attachment 337506
[details]
Patch for landing Clearing flags on attachment: 337506 Committed
r230490
: <
https://trac.webkit.org/changeset/230490
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug