Bug 184364 - WebCore::screenSupportsExtendedColor improperly calls NSScreen functions in the WebContent process
Summary: WebCore::screenSupportsExtendedColor improperly calls NSScreen functions in t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 184367
  Show dependency tree / graph
 
Reported: 2018-04-06 12:42 PDT by Brent Fulgham
Modified: 2018-04-10 09:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2018-04-06 13:31 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (5.26 KB, patch)
2018-04-06 14:54 PDT, Brent Fulgham 		bfulgham: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-04-06 12:42:02 PDT 
WebCore::screenSupportsExtendedColor is interacting with the NSScreen/NSDisplay system in the WebContent process. This should be brokered from the UIProcess.
Comment 1 Brent Fulgham 2018-04-06 12:51:28 PDT 
Tested by fast/media/mq-color-gamut.html.
Comment 2 Radar WebKit Bug Importer 2018-04-06 12:52:07 PDT 
<rdar://problem/39246314>
Comment 3 Brent Fulgham 2018-04-06 13:31:15 PDT 
Created attachment 337386 [details]
Patch
Comment 4 Per Arne Vollan 2018-04-06 13:59:24 PDT 
Comment on attachment 337386 [details]
Patch

Very nice! R=me.
Comment 5 Brent Fulgham 2018-04-06 14:54:40 PDT 
Created attachment 337391 [details]
Patch for landing
Comment 6 Brent Fulgham 2018-04-06 15:54:39 PDT 
Committed r230356: <https://trac.webkit.org/changeset/230356>