The user of this API is Wasm. Currently, treating this as dirty is worse than treating it as non-dirty, since it'll make iOS think it's constantly under memory pressure. We should eventually implement something that has a more perfect idea of the total dirty memory, but let's start with this as a stop gap.
Created attachment 337323 [details] patch
Attachment 337323 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/bmalloc.h:85: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/bmalloc/bmalloc/bmalloc.h:85: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 337323 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=337323&action=review r=me > Source/bmalloc/ChangeLog:13 > + we vend as dirty, versus what we do now, which is treat is all as dirty. typo: /treat is all/treat it all/. > Source/bmalloc/ChangeLog:15 > + scavenger think its under memory pressure because memory it can't free isn't /because memory/because of memory/.
Created attachment 337399 [details] patch for landing
Attachment 337399 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/bmalloc.h:85: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/bmalloc/bmalloc/bmalloc.h:85: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 337399 [details] patch for landing Clearing flags on attachment: 337399 Committed r230360: <https://trac.webkit.org/changeset/230360>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39253734>