Bug 184326 - WebContent process sometimes hangs in WebProcess::ensureNetworkProcessConnection
Summary: WebContent process sometimes hangs in WebProcess::ensureNetworkProcessConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-04 22:48 PDT by Ryosuke Niwa
Modified: 2018-04-05 14:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.12 KB, patch)
2018-04-04 23:03 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (6.15 KB, patch)
2018-04-05 13:36 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-04-04 22:48:27 PDT 
Sometimes we see WebContent process hanging inside WebProcess::ensureNetworkProcessConnection while it's getting started up.

<rdar://problem/38563780>
Comment 1 Ryosuke Niwa 2018-04-04 23:03:12 PDT 
Created attachment 337255 [details]
Patch
Comment 2 Chris Dumez 2018-04-05 13:22:48 PDT 
Comment on attachment 337255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337255&action=review

> Source/WebKit/Platform/IPC/Connection.h:340
> +    bool m_initializingSendSource { false };

I think we should use a prefix since this is a Boolean variable, I suggest: m_isInitializingSendSource.
Comment 3 Ryosuke Niwa 2018-04-05 13:25:42 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 337255 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337255&action=review
> 
> > Source/WebKit/Platform/IPC/Connection.h:340
> > +    bool m_initializingSendSource { false };
> 
> I think we should use a prefix since this is a Boolean variable, I suggest:
> m_isInitializingSendSource.

Sure, will fix.

Thanks for the review.
Comment 4 Ryosuke Niwa 2018-04-05 13:36:26 PDT 
Created attachment 337293 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-04-05 14:21:55 PDT 
Comment on attachment 337293 [details]
Patch for landing

Clearing flags on attachment: 337293

Committed r230314: <https://trac.webkit.org/changeset/230314>
Comment 6 WebKit Commit Bot 2018-04-05 14:21:56 PDT 
All reviewed patches have been landed.  Closing bug.