Bug 184326 – WebContent process sometimes hangs in WebProcess::ensureNetworkProcessConnection

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ryosuke Niwa]

Sometimes we see WebContent process hanging inside WebProcess::ensureNetworkProcessConnection while it's getting started up.

<rdar://problem/38563780>

[Ryosuke Niwa]

Created attachment 337255 [details]
Patch

[Chris Dumez]

Comment on attachment 337255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337255&action=review

> Source/WebKit/Platform/IPC/Connection.h:340
> +    bool m_initializingSendSource { false };

I think we should use a prefix since this is a Boolean variable, I suggest: m_isInitializingSendSource.

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 337255 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337255&action=review
> 
> > Source/WebKit/Platform/IPC/Connection.h:340
> > +    bool m_initializingSendSource { false };
> 
> I think we should use a prefix since this is a Boolean variable, I suggest:
> m_isInitializingSendSource.

Sure, will fix.

Thanks for the review.

[Ryosuke Niwa]

Created attachment 337293 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 337293 [details]
Patch for landing

Clearing flags on attachment: 337293

Committed r230314: <https://trac.webkit.org/changeset/230314>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.