Bug 184325 – fetch() with subresource integrity crashes on zero length body

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Lars Mikkelsen]

If the 'integrity' option is used for the fetch() method it will cause a crash when the response has a zero length body. This is reproducible using:

fetch('https://httpbin.org/bytes/0', {integrity: 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU='});

This affects at least Safari 11.1, Safari Technology Preview 53, and WebKit r230285.

[Lars Mikkelsen]

Created attachment 337247 [details]
com.apple.WebKit.WebContent.crash

[Radar WebKit Bug Importer]

<rdar://problem/39262568>

[Rob Buis]

Created attachment 346628 [details]
Patch

[EWS Watchlist]

Attachment 346628 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Created attachment 346689 [details]
Patch

[EWS Watchlist]

Comment on attachment 346689 [details]
Patch

Attachment 346689 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8785226

New failing tests:
http/tests/subresource-integrity/sri-fetch-worker.html

[EWS Watchlist]

Created attachment 346691 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346689 [details]
Patch

Attachment 346689 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8785244

New failing tests:
http/tests/subresource-integrity/sri-fetch-worker.html

[EWS Watchlist]

Created attachment 346692 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346689 [details]
Patch

Attachment 346689 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8785303

New failing tests:
http/tests/subresource-integrity/sri-fetch-worker.html

[EWS Watchlist]

Created attachment 346694 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346689 [details]
Patch

Attachment 346689 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8785321

New failing tests:
http/tests/subresource-integrity/sri-fetch-worker.html

[EWS Watchlist]

Created attachment 346696 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Rob Buis]

Created attachment 346705 [details]
Patch

[Alex Christensen]

Comment on attachment 346705 [details]
Patch

Great!

[WebKit Commit Bot]

Comment on attachment 346705 [details]
Patch

Clearing flags on attachment: 346705

Committed r234678: <https://trac.webkit.org/changeset/234678>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.