Bug 184317 - http/wpt/loading/redirect-headers.html is flaky
Summary: http/wpt/loading/redirect-headers.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-04 14:44 PDT by youenn fablet
Modified: 2018-04-04 19:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2018-04-04 14:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.30 KB, patch)
2018-04-04 15:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-04-04 14:44:03 PDT 
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/wpt/loading/redirect-headers-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/wpt/loading/redirect-headers-actual.txt
@@ -7,5 +7,4 @@
 http://localhost:8800/WebKit/loading/redirect-headers.html - didFinishLoading
 http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - willSendRequest <NSURLRequest URL http://localhost:8800/?status=302&location=%2F&count=1, main document URL http://localhost:8800/WebKit/loading/redirect-headers.html, http method GET> redirectResponse <NSURLResponse http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/, http status code 302, 6 headers>
 http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - didReceiveResponse <NSURLResponse http://localhost:8800/?status=302&location=%2F&count=1, http status code 200>
-http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - didFinishLoadin
Comment 1 youenn fablet 2018-04-04 14:45:56 PDT 
Created attachment 337229 [details]
Patch
Comment 2 Ryosuke Niwa 2018-04-04 15:44:02 PDT 
Comment on attachment 337229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337229&action=review

> LayoutTests/http/wpt/loading/redirect-headers.html:12
> +    let response = await fetch("../beacon/resources/redirect.py?status=302&location=/");

Use const?
Comment 3 youenn fablet 2018-04-04 15:46:52 PDT 
Created attachment 337234 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-04-04 19:06:14 PDT 
Comment on attachment 337234 [details]
Patch for landing

Clearing flags on attachment: 337234

Committed r230291: <https://trac.webkit.org/changeset/230291>
Comment 5 WebKit Commit Bot 2018-04-04 19:06:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-04-04 19:07:30 PDT 
<rdar://problem/39197157>