Bug 184315 – Add a test for scoped cookies used to load AppCache resources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Add a test for scoped cookies used to load AppCache resources

[youenn fablet]

Created attachment 337227 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 337227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337227&action=review

> LayoutTests/http/tests/appcache/document-cookie-http-only.php:-2
> -setcookie("foo", "bar", 0, "/", null, null, true);

Don't we want to keep the test for regular cookies?

[youenn fablet]

(In reply to Ryosuke Niwa from comment #2)
> Comment on attachment 337227 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337227&action=review
> 
> > LayoutTests/http/tests/appcache/document-cookie-http-only.php:-2
> > -setcookie("foo", "bar", 0, "/", null, null, true);
> 
> Don't we want to keep the test for regular cookies?

The test is moving from using one HttpOnly cookie to two HttpOnly cookies.
So we are not losing coverage here.

We have other tests that are covering non HttpOnly cookies.

It would be easy to modify this test to cache another script protected by a regular non-scoped cookie. Is that your suggestion?

[Ryosuke Niwa]

(In reply to youenn fablet from comment #3)
> (In reply to Ryosuke Niwa from comment #2)
> > Comment on attachment 337227 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=337227&action=review
> > 
> > > LayoutTests/http/tests/appcache/document-cookie-http-only.php:-2
> > > -setcookie("foo", "bar", 0, "/", null, null, true);
> > 
> > Don't we want to keep the test for regular cookies?
> 
> The test is moving from using one HttpOnly cookie to two HttpOnly cookies.
> So we are not losing coverage here.
> 
> We have other tests that are covering non HttpOnly cookies.
> 
> It would be easy to modify this test to cache another script protected by a
> regular non-scoped cookie. Is that your suggestion?

Yes, that's my suggestion.

[youenn fablet]

Created attachment 337342 [details]
Patch

[youenn fablet]

Created attachment 337345 [details]
Fixing flakiness

[WebKit Commit Bot]

Comment on attachment 337345 [details]
Fixing flakiness

Clearing flags on attachment: 337345

Committed r230328: <https://trac.webkit.org/changeset/230328>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39231738>