Bug 184301 - Enable Gigacage unconditionally when building JSCOnly on macOS (build fix)
Summary: Enable Gigacage unconditionally when building JSCOnly on macOS (build fix)
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
Keywords: InRadar
Depends on:
Reported: 2018-04-04 06:56 PDT by Konstantin Tokarev
Modified: 2018-04-04 08:02 PDT (History)
5 users (show)

See Also:

Patch (2.65 KB, patch)
2018-04-04 07:00 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff
Patch (2.69 KB, patch)
2018-04-04 07:17 PDT, Konstantin Tokarev
ysuzuki: review+
annulen: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2018-04-04 06:56:32 PDT
bmalloc/ProcessCheck.mm implements specific behavior for Mac and iOS ports, which is guarded with BPLATFORM(COCOA). We should not enable BPLATFORM(MAC) or BPLATFORM(IOS) in JSCOnly, then BPLATFORM(COCOA) won't be defined as well, and code path from ProcessCheck.mm will not be taken
Comment 1 Konstantin Tokarev 2018-04-04 07:00:56 PDT
Created attachment 337162 [details]
Comment 2 Yusuke Suzuki 2018-04-04 07:02:19 PDT
Comment on attachment 337162 [details]

Comment 3 Konstantin Tokarev 2018-04-04 07:03:06 PDT
Should fix GTK/macOS too.
Comment 4 Konstantin Tokarev 2018-04-04 07:17:05 PDT
Created attachment 337163 [details]
Comment 5 Konstantin Tokarev 2018-04-04 07:17:32 PDT
Now it should actually fix GTK/macOS
Comment 6 Yusuke Suzuki 2018-04-04 07:28:48 PDT
Comment on attachment 337163 [details]

r=me since Mac does not have maintained CMake port right now.
Comment 7 Konstantin Tokarev 2018-04-04 07:31:20 PDT
Note that I've defined BPLATFORM_MAC in PlatformMac, so it should not make things worse for Mac/CMake
Comment 8 Konstantin Tokarev 2018-04-04 08:00:29 PDT
Committed r230255: <https://trac.webkit.org/changeset/230255>
Comment 9 Radar WebKit Bug Importer 2018-04-04 08:02:19 PDT