RESOLVED FIXED 184296
[Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPixelsPerLine) 
https://bugs.webkit.org/show_bug.cgi?id=184296
Summary [Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPix...
Fujii Hironori
Reported 2018-04-04 03:29:08 PDT
[Win][WebCore] New API to get scrollbar pixels per line (cScrollbarPixelsPerLine) A constant `cScrollbarPixelsPerLine` is defined in multiple codes. WebCore/platform/win/WheelEventWin.cpp DumpRenderTree/win/EventSender.cpp
Attachments
Patch (5.79 KB, patch)
2018-04-04 03:45 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (5.73 KB, patch)
2018-04-05 20:37 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-04-04 03:35:31 PDT
(In reply to Brent Fulgham from bug#183043 comment #5) > > Source/WebKit/Shared/win/WebEventFactory.cpp:400 > > + static const float cScrollbarPixelsPerLine = 100.0f / 3.0f; > > We should probably expose this from WebCore in some useful way, since we now > have this hard-coded in two places.
Fujii Hironori
Comment 2 2018-04-04 03:45:01 PDT
Created attachment 337155 [details] Patch
Alex Christensen
Comment 3 2018-04-04 09:49:48 PDT
Comment on attachment 337155 [details] Patch This doubles the calls to ::GetDeviceCaps when scrolling.
Fujii Hironori
Comment 4 2018-04-05 20:37:02 PDT
Created attachment 337337 [details] Patch
WebKit Commit Bot
Comment 5 2018-04-06 13:30:21 PDT
Comment on attachment 337337 [details] Patch Clearing flags on attachment: 337337 Committed r230355: <https://trac.webkit.org/changeset/230355>
WebKit Commit Bot
Comment 6 2018-04-06 13:30:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-06 13:31:19 PDT
<rdar://problem/39247433>
Note You need to log in before you can comment on or make changes to this bug.