Bug 184296 - [Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPixelsPerLine)
Summary: [Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPix...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 183043
  Show dependency tree / graph
 
Reported: 2018-04-04 03:29 PDT by Fujii Hironori
Modified: 2018-04-06 13:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.79 KB, patch)
2018-04-04 03:45 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (5.73 KB, patch)
2018-04-05 20:37 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-04-04 03:29:08 PDT 
[Win][WebCore] New API to get scrollbar pixels per line (cScrollbarPixelsPerLine)

A constant `cScrollbarPixelsPerLine` is defined in multiple codes.

WebCore/platform/win/WheelEventWin.cpp
DumpRenderTree/win/EventSender.cpp
Comment 1 Fujii Hironori 2018-04-04 03:35:31 PDT 
(In reply to Brent Fulgham from bug#183043 comment #5)
> > Source/WebKit/Shared/win/WebEventFactory.cpp:400
> > +    static const float cScrollbarPixelsPerLine = 100.0f / 3.0f;
> 
> We should probably expose this from WebCore in some useful way, since we now
> have this hard-coded in two places.
Comment 2 Fujii Hironori 2018-04-04 03:45:01 PDT 
Created attachment 337155 [details]
Patch
Comment 3 Alex Christensen 2018-04-04 09:49:48 PDT 
Comment on attachment 337155 [details]
Patch

This doubles the calls to ::GetDeviceCaps when scrolling.
Comment 4 Fujii Hironori 2018-04-05 20:37:02 PDT 
Created attachment 337337 [details]
Patch
Comment 5 WebKit Commit Bot 2018-04-06 13:30:21 PDT 
Comment on attachment 337337 [details]
Patch

Clearing flags on attachment: 337337

Committed r230355: <https://trac.webkit.org/changeset/230355>
Comment 6 WebKit Commit Bot 2018-04-06 13:30:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-06 13:31:19 PDT 
<rdar://problem/39247433>