Bug 184274 - Test expectation updater should handle Win bot results
Summary: Test expectation updater should handle Win bot results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-03 11:38 PDT by youenn fablet
Modified: 2018-04-05 22:01 PDT (History)
10 users (show)

See Also:


Attachments
Patch (26.96 KB, patch)
2018-04-03 11:41 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (27.01 KB, patch)
2018-04-05 21:07 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-04-03 11:38:34 PDT
Test expectation updater should handle Win bot results
Comment 1 youenn fablet 2018-04-03 11:41:56 PDT
Created attachment 337099 [details]
Patch
Comment 2 Ryosuke Niwa 2018-04-05 18:51:35 PDT
Comment on attachment 337099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337099&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:159
> +        updater = TestExpectationUpdater(host, "123456", True, False, MockBugzilla(False, True), lambda content: mock_zip.unzip(content))

Nit: please do: MockBugzilla(include_wk2=False, include_win_future=True) to make the code more readable.
Comment 3 youenn fablet 2018-04-05 21:07:53 PDT
Created attachment 337341 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-04-05 22:00:14 PDT
Comment on attachment 337341 [details]
Patch for landing

Clearing flags on attachment: 337341

Committed r230325: <https://trac.webkit.org/changeset/230325>
Comment 5 WebKit Commit Bot 2018-04-05 22:00:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-04-05 22:01:31 PDT
<rdar://problem/39230285>