RESOLVED FIXED184274
Test expectation updater should handle Win bot results 
https://bugs.webkit.org/show_bug.cgi?id=184274
Summary Test expectation updater should handle Win bot results
youenn fablet
Reported 2018-04-03 11:38:34 PDT
Test expectation updater should handle Win bot results
Attachments
Patch (26.96 KB, patch)
2018-04-03 11:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.01 KB, patch)
2018-04-05 21:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-04-03 11:41:56 PDT
Created attachment 337099 [details] Patch
Ryosuke Niwa
Comment 2 2018-04-05 18:51:35 PDT
Comment on attachment 337099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337099&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:159 > + updater = TestExpectationUpdater(host, "123456", True, False, MockBugzilla(False, True), lambda content: mock_zip.unzip(content)) Nit: please do: MockBugzilla(include_wk2=False, include_win_future=True) to make the code more readable.
youenn fablet
Comment 3 2018-04-05 21:07:53 PDT
Created attachment 337341 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-04-05 22:00:14 PDT
Comment on attachment 337341 [details] Patch for landing Clearing flags on attachment: 337341 Committed r230325: <https://trac.webkit.org/changeset/230325>
WebKit Commit Bot
Comment 5 2018-04-05 22:00:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-04-05 22:01:31 PDT
<rdar://problem/39230285>
Note You need to log in before you can comment on or make changes to this bug.